public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Doug Kehn <rdkehn@yahoo.com>
To: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: [PATCH] ksz884x: fix mtu for VLAN
Date: Wed, 11 Jan 2012 12:21:46 -0800 (PST)	[thread overview]
Message-ID: <1326313306.57525.YahooMailNeo@web39305.mail.mud.yahoo.com> (raw)

The Ethernet header does not account for the addition of a VLAN header.
Full size Ethernet frames containing VLAN header are not processed
because the frame is larger than the resulting hw mtu.

Signed-off-by: Doug Kehn <rdkehn@yahoo.com>
---
 drivers/net/ethernet/micrel/ksz884x.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/ethernet/micrel/ksz884x.c b/drivers/net/ethernet/micrel/ksz884x.c
index 6ed09a8..e52cd31 100644
--- a/drivers/net/ethernet/micrel/ksz884x.c
+++ b/drivers/net/ethernet/micrel/ksz884x.c
@@ -746,7 +746,7 @@
 #define MAC_ADDR_ORDER(i)        (ETH_ALEN - 1 - (i))
 
 #define MAX_ETHERNET_BODY_SIZE        1500
-#define ETHERNET_HEADER_SIZE        14
+#define ETHERNET_HEADER_SIZE        (14 + VLAN_HLEN)
 
 #define MAX_ETHERNET_PACKET_SIZE    \
     (MAX_ETHERNET_BODY_SIZE + ETHERNET_HEADER_SIZE)
-- 
1.7.4.1

             reply	other threads:[~2012-01-11 20:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-11 20:21 Doug Kehn [this message]
2012-01-11 20:47 ` [PATCH] ksz884x: fix mtu for VLAN David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1326313306.57525.YahooMailNeo@web39305.mail.mud.yahoo.com \
    --to=rdkehn@yahoo.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox