From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: "Vick, Matthew" <matthew.vick@intel.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"gospo@redhat.com" <gospo@redhat.com>,
"sassmann@redhat.com" <sassmann@redhat.com>
Subject: Re: [ethtool] ethtool: Correct register dump offsets for Intel 82575 chipsets.
Date: Thu, 12 Jan 2012 05:11:02 -0800 [thread overview]
Message-ID: <1326373862.2709.63.camel@jtkirshe-mobl> (raw)
In-Reply-To: <1324636371-5402-1-git-send-email-jeffrey.t.kirsher@intel.com>
[-- Attachment #1: Type: text/plain, Size: 2271 bytes --]
On Fri, 2011-12-23 at 02:32 -0800, Kirsher, Jeffrey T wrote:
> From: Matthew Vick <matthew.vick@intel.com>
>
> When support was added to dump the registers on 82575 chipset devices,
> six register offsets (receive/transmit desc length, head, and tail)
> were incorrectly mapped. This patch remaps the offsets to the correct
> registers.
>
> Signed-off-by: Matthew Vick <matthew.vick@intel.com>
> Tested-by: Aaron Brown <aaron.f.brown@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> ---
> igb.c | 12 ++++++------
> 1 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/igb.c b/igb.c
> index ec35d36..e0ccef9 100644
> --- a/igb.c
> +++ b/igb.c
> @@ -200,13 +200,13 @@ igb_dump_regs(struct ethtool_drvinfo *info, struct ethtool_regs *regs)
> /* Receive descriptor registers */
> fprintf(stdout,
> "0x02808: RDLEN (Receive desc length) 0x%08X\n",
> - regs_buff[142]);
> + regs_buff[137]);
> fprintf(stdout,
> "0x02810: RDH (Receive desc head) 0x%08X\n",
> - regs_buff[146]);
> + regs_buff[141]);
> fprintf(stdout,
> "0x02818: RDT (Receive desc tail) 0x%08X\n",
> - regs_buff[150]);
> + regs_buff[145]);
>
> /* Transmit control register */
> reg = regs_buff[38];
> @@ -226,13 +226,13 @@ igb_dump_regs(struct ethtool_drvinfo *info, struct ethtool_regs *regs)
> /* Transmit descriptor registers */
> fprintf(stdout,
> "0x03808: TDLEN (Transmit desc length) 0x%08X\n",
> - regs_buff[214]);
> + regs_buff[219]);
> fprintf(stdout,
> "0x03810: TDH (Transmit desc head) 0x%08X\n",
> - regs_buff[218]);
> + regs_buff[223]);
> fprintf(stdout,
> "0x03818: TDT (Transmit desc tail) 0x%08X\n",
> - regs_buff[222]);
> + regs_buff[227]);
>
>
> fprintf(stdout,
> --
> 1.7.7.4
>
Ben, what is the status of this patch?
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-01-12 13:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-23 10:32 [ethtool] ethtool: Correct register dump offsets for Intel 82575 chipsets Jeff Kirsher
2012-01-12 13:11 ` Jeff Kirsher [this message]
2012-01-12 14:08 ` Ben Hutchings
2012-01-12 14:35 ` Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1326373862.2709.63.camel@jtkirshe-mobl \
--to=jeffrey.t.kirsher@intel.com \
--cc=bhutchings@solarflare.com \
--cc=gospo@redhat.com \
--cc=matthew.vick@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).