From: Eric Dumazet <eric.dumazet@gmail.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Mike Christie <michaelc@cs.wisc.edu>,
Eric Paris <eparis@redhat.com>
Subject: Re: Consequences of commit 16e5726269611b71c930054ffe9b858c1cea88eb
Date: Thu, 12 Jan 2012 21:59:03 +0100 [thread overview]
Message-ID: <1326401943.2617.0.camel@edumazet-laptop> (raw)
In-Reply-To: <CAO+b5-pGcKbTYQWdWo=kbiQ2ORbgn8GAV_cfYjGzOARmgrsUxQ@mail.gmail.com>
Le jeudi 12 janvier 2012 à 19:14 +0000, Bart Van Assche a écrit :
> Hi,
>
> If my analysis is correct commit
> 16e5726269611b71c930054ffe9b858c1cea88eb ("af_unix: dont send
> SCM_CREDENTIALS by default") changes the value of
> NETLINK_CREDS(skb)->pid from the sender pid into zero. Does that mean
> that the code using that construct did work in kernel 3.1 but that it
> is broken in kernel 3.2 ? Should that commit be reverted or will
> someone fix the code that uses NETLINK_CREDS() ? Would changing
> NETLINK_CREDS(skb)->pid into NETLINK_CB(skb).pid be sufficient ?
>
> Thanks,
>
> Bart.
>
> $ git grep 'NETLINK_CREDS([a-zA-Z0-9_]*)->pid'
> drivers/scsi/scsi_netlink.c: pid = NETLINK_CREDS(skb)->pid;
> kernel/audit.c: pid = NETLINK_CREDS(skb)->pid;
What is your problem exactly ?
next prev parent reply other threads:[~2012-01-12 20:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-12 19:14 Consequences of commit 16e5726269611b71c930054ffe9b858c1cea88eb Bart Van Assche
2012-01-12 20:59 ` Eric Dumazet [this message]
2012-01-13 5:50 ` Eric Dumazet
2012-01-13 7:20 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1326401943.2617.0.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=bvanassche@acm.org \
--cc=davem@davemloft.net \
--cc=eparis@redhat.com \
--cc=michaelc@cs.wisc.edu \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox