From: "Rafał Miłecki" <zajec5@gmail.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: "Network Development" <netdev@vger.kernel.org>,
"Linus Torvalds" <torvalds@linux-foundation.org>,
"Arend van Spriel" <arend@broadcom.com>,
"Larry Finger" <Larry.Finger@lwfinger.net>,
"Alwin Beukers" <alwin@broadcom.com>,
"Roland Vossen" <rvossen@broadcom.com>,
"Franky (Zhenhui) Lin" <frankyl@broadcom.com>,
"Rafał Miłecki" <zajec5@gmail.com>
Subject: [PATCH V2 2/5] bcma: convert suspend/resume to pm_ops
Date: Fri, 13 Jan 2012 23:58:39 +0100 [thread overview]
Message-ID: <1326495522-6024-2-git-send-email-zajec5@gmail.com> (raw)
In-Reply-To: <1326495522-6024-1-git-send-email-zajec5@gmail.com>
From: Linus Torvalds <torvalds@linux-foundation.org>
.. and avoid doing the unnecessary PCI operations - the PCI layer will
do them for us.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
---
drivers/bcma/host_pci.c | 42 ++++++++++++++++--------------------------
1 files changed, 16 insertions(+), 26 deletions(-)
diff --git a/drivers/bcma/host_pci.c b/drivers/bcma/host_pci.c
index c1ca9e3..86dfeea 100644
--- a/drivers/bcma/host_pci.c
+++ b/drivers/bcma/host_pci.c
@@ -235,41 +235,32 @@ static void bcma_host_pci_remove(struct pci_dev *dev)
}
#ifdef CONFIG_PM
-static int bcma_host_pci_suspend(struct pci_dev *dev, pm_message_t state)
+static int bcma_host_pci_suspend(struct device *dev)
{
- struct bcma_bus *bus = pci_get_drvdata(dev);
-
- /* Host specific */
- pci_save_state(dev);
- pci_disable_device(dev);
- pci_set_power_state(dev, pci_choose_state(dev, state));
+ struct pci_dev *pdev = to_pci_dev(dev);
+ struct bcma_bus *bus = pci_get_drvdata(pdev);
bus->mapped_core = NULL;
+
return 0;
}
-static int bcma_host_pci_resume(struct pci_dev *dev)
+static int bcma_host_pci_resume(struct device *dev)
{
- struct bcma_bus *bus = pci_get_drvdata(dev);
- int err;
+ struct pci_dev *pdev = to_pci_dev(dev);
+ struct bcma_bus *bus = pci_get_drvdata(pdev);
- /* Host specific */
- pci_set_power_state(dev, 0);
- err = pci_enable_device(dev);
- if (err)
- return err;
- pci_restore_state(dev);
+ return bcma_bus_resume(bus);
+}
- /* Bus specific */
- err = bcma_bus_resume(bus);
- if (err)
- return err;
+static SIMPLE_DEV_PM_OPS(bcma_pm_ops, bcma_host_pci_suspend,
+ bcma_host_pci_resume);
+#define BCMA_PM_OPS (&bcma_pm_ops)
- return 0;
-}
#else /* CONFIG_PM */
-# define bcma_host_pci_suspend NULL
-# define bcma_host_pci_resume NULL
+
+#define BCMA_PM_OPS NULL
+
#endif /* CONFIG_PM */
static DEFINE_PCI_DEVICE_TABLE(bcma_pci_bridge_tbl) = {
@@ -287,8 +278,7 @@ static struct pci_driver bcma_pci_bridge_driver = {
.id_table = bcma_pci_bridge_tbl,
.probe = bcma_host_pci_probe,
.remove = bcma_host_pci_remove,
- .suspend = bcma_host_pci_suspend,
- .resume = bcma_host_pci_resume,
+ .driver.pm = BCMA_PM_OPS,
};
int __init bcma_host_pci_init(void)
--
1.7.7
next prev parent reply other threads:[~2012-01-13 22:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-13 22:58 [PATCH V2 1/5][STABLE] bcma: invalidate the mapped core over suspend/resume Rafał Miłecki
2012-01-13 22:58 ` Rafał Miłecki [this message]
2012-01-13 22:58 ` [PATCH V2 3/5] bcma: add stub for bcma_bus_suspend() Rafał Miłecki
2012-01-13 22:58 ` [PATCH V2 4/5] bcma: connect the bcma bus suspend/resume to the bcma driver suspend/resume Rafał Miłecki
2012-01-13 22:58 ` [PATCH V2 5/5] brcmsmac: remove PCI suspend/resume from bcma driver Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1326495522-6024-2-git-send-email-zajec5@gmail.com \
--to=zajec5@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=alwin@broadcom.com \
--cc=arend@broadcom.com \
--cc=frankyl@broadcom.com \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=rvossen@broadcom.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).