Netdev List
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Hiroaki SHIMODA <shimoda.hiroaki@gmail.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, therbert@google.com
Subject: Re: [PATCH net] dql: Fix inconsistency between file mode and attr method.
Date: Sat, 14 Jan 2012 18:21:11 +0100	[thread overview]
Message-ID: <1326561671.5287.27.camel@edumazet-laptop> (raw)
In-Reply-To: <20120115021021.1bb055da.shimoda.hiroaki@gmail.com>

Le dimanche 15 janvier 2012 à 02:10 +0900, Hiroaki SHIMODA a écrit :
> There is no store() method for inflight attribute in the
> tx-<n>/byte_queue_limits sysfs directory.
> So remove S_IWUSR bit.
> 
> Signed-off-by: Hiroaki SHIMODA <shimoda.hiroaki@gmail.com>
> ---
>  net/core/net-sysfs.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c
> index f3dbd4f..a1727cd 100644
> --- a/net/core/net-sysfs.c
> +++ b/net/core/net-sysfs.c
> @@ -929,7 +929,7 @@ static ssize_t bql_show_inflight(struct netdev_queue *queue,
>  }
>  
>  static struct netdev_queue_attribute bql_inflight_attribute =
> -	__ATTR(inflight, S_IRUGO | S_IWUSR, bql_show_inflight, NULL);
> +	__ATTR(inflight, S_IRUGO, bql_show_inflight, NULL);
>  
>  #define BQL_ATTR(NAME, FIELD)						\
>  static ssize_t bql_show_ ## NAME(struct netdev_queue *queue,		\

Acked-by: Eric Dumazet <eric.dumazet@gmail.com>

  reply	other threads:[~2012-01-14 17:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-14 17:10 [PATCH net] dql: Fix inconsistency between file mode and attr method Hiroaki SHIMODA
2012-01-14 17:21 ` Eric Dumazet [this message]
2012-01-17 15:06 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1326561671.5287.27.camel@edumazet-laptop \
    --to=eric.dumazet@gmail.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=shimoda.hiroaki@gmail.com \
    --cc=therbert@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox