From: Joe Perches <joe@perches.com>
To: David Miller <davem@davemloft.net>
Cc: dvhart@linux.intel.com, linux-kernel@vger.kernel.org,
arjan@linux.intel.com, alan@linux.intel.com,
tomoya.rohm@gmail.com, jeffrey.t.kirsher@intel.com,
paul.gortmaker@windriver.com, jdmason@kudzu.us,
netdev@vger.kernel.org
Subject: Re: [PATCH] pch_gbe: Use a randomly generated MAC instead of failing probe
Date: Sat, 14 Jan 2012 12:29:25 -0800 [thread overview]
Message-ID: <1326572965.6300.103.camel@joe2Laptop> (raw)
In-Reply-To: <20120114.115604.2101782124431552110.davem@davemloft.net>
On Sat, 2012-01-14 at 11:56 -0800, David Miller wrote:
> From: Darren Hart <dvhart@linux.intel.com>
> Date: Sat, 14 Jan 2012 07:54:27 -0800
> > In any case, with existing hardware out there that is unusable with the
> > current pch_gbe driver, can we consider this workaround for inclusion?
> I fear that people are just going to add this random MAC stuff way too
> easily, it's a spreading disease.
> Ship functional hardware instead.
Good advice, but that's _hard_.
Working systems are nearly always some combination
of hardware/firmware/software defect workarounds.
Anyway, perhaps setting random_ether_addr like this
should be in some generic routine with a standardized
"avoid buying bad hardware" output logging message.
next prev parent reply other threads:[~2012-01-14 20:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-14 6:44 [PATCH] pch_gbe: Use a randomly generated MAC instead of failing probe Darren Hart
2012-01-14 8:14 ` David Miller
2012-01-14 15:54 ` Darren Hart
2012-01-14 19:56 ` David Miller
2012-01-14 20:29 ` Joe Perches [this message]
2012-01-14 21:46 ` Alan Cox
2012-01-14 22:36 ` Darren Hart
2012-01-16 7:38 ` Tomoya MORINAGA
2012-01-16 12:31 ` Alan Cox
2012-01-16 15:42 ` Darren Hart
2012-01-16 16:07 ` Arjan van de Ven
2012-01-16 16:20 ` David Laight
2012-01-16 16:35 ` Arjan van de Ven
2012-01-16 16:44 ` Mark Brown
2012-01-16 17:02 ` Alan Cox
2012-01-16 21:06 ` Rick Jones
2012-01-16 15:38 ` Darren Hart
2012-01-14 8:15 ` David Miller
2012-01-14 8:18 ` Cong Wang
2012-01-14 15:45 ` Darren Hart
2012-01-16 15:22 ` Nick Bowler
2012-01-16 23:04 ` David Miller
2012-01-16 23:07 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1326572965.6300.103.camel@joe2Laptop \
--to=joe@perches.com \
--cc=alan@linux.intel.com \
--cc=arjan@linux.intel.com \
--cc=davem@davemloft.net \
--cc=dvhart@linux.intel.com \
--cc=jdmason@kudzu.us \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=tomoya.rohm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).