From: Joe Perches <joe@perches.com>
To: Arend van Spriel <arend@broadcom.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Brett Rudley <brudley@broadcom.com>,
Henry Ptasinski <henryp@broadcom.com>,
Roland Vossen <rvossen@broadcom.com>,
"Franky (Zhenhui) Lin" <frankyl@broadcom.com>,
Kan Yan <kanyan@broadcom.com>,
"John W. Linville" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH 3/8] brcm80211: Add and use brcmX_dbg_dump_hex
Date: Sun, 15 Jan 2012 01:21:50 -0800 [thread overview]
Message-ID: <1326619310.6164.2.camel@joe2Laptop> (raw)
In-Reply-To: <4F1299C4.7020902@broadcom.com>
On Sun, 2012-01-15 at 10:17 +0100, Arend van Spriel wrote:
> On 01/15/2012 09:38 AM, Joe Perches wrote:
>
> > +#ifdef DEBUG
> > +extern __printf(3, 4)
>
> Just curious if I can learn something here. What does the __printf(3, 4) do?
It's a #define for gcc __attribute__((format (printf, ...)))
It makes gcc validate the printf format and arguments.
http://gcc.gnu.org/onlinedocs/gcc/Function-Attributes.html
next prev parent reply other threads:[~2012-01-15 9:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-15 8:38 [PATCH 0/8] brcm80211: Logging cleanups Joe Perches
[not found] ` <cover.1326616556.git.joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2012-01-15 8:38 ` [PATCH 1/8] brcm80211: Use normal DEBUG define Joe Perches
2012-01-15 8:38 ` [PATCH 2/8] brcmfmac: Convert printk(KERN_DEBUG to pr_debug Joe Perches
2012-01-15 8:38 ` [PATCH 3/8] brcm80211: Add and use brcmX_dbg_dump_hex Joe Perches
2012-01-15 9:17 ` Arend van Spriel
2012-01-15 9:21 ` Joe Perches [this message]
2012-01-15 8:38 ` [PATCH 4/8] brcmfmac: Remove useless #ifdef DEBUG Joe Perches
2012-01-15 8:38 ` [PATCH 5/8] brcm80211: Convert printk(KERN_DEBUG to pr_debug Joe Perches
2012-01-15 8:38 ` [PATCH 6/8] brcm80211: Use brcmu_dbg_hex_dump Joe Perches
2012-01-15 8:38 ` [PATCH 7/8] brcm80211: Use pr_fmt and pr_<level> Joe Perches
2012-01-15 8:38 ` [PATCH 8/8] brcmfmac: Trivial typo of "couldn" to "could" fix Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1326619310.6164.2.camel@joe2Laptop \
--to=joe@perches.com \
--cc=arend@broadcom.com \
--cc=brudley@broadcom.com \
--cc=frankyl@broadcom.com \
--cc=henryp@broadcom.com \
--cc=kanyan@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=rvossen@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).