From: Wei Liu <wei.liu2@citrix.com>
To: David Vrabel <dvrabel@cantab.net>
Cc: <wei.liu2@citrix.com>, Ian Campbell <Ian.Campbell@citrix.com>,
"konrad.wilk@oracle.com" <konrad.wilk@oracle.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [Xen-devel] [RFC PATCH 2/6] netback: add module unload function.
Date: Mon, 16 Jan 2012 09:31:58 +0000 [thread overview]
Message-ID: <1326706318.5285.4.camel@liuw-desktop> (raw)
In-Reply-To: <4F10709B.8070804@cantab.net>
On Fri, 2012-01-13 at 17:57 +0000, David Vrabel wrote:
> On 13/01/12 16:59, Wei Liu wrote:
> > Enables users to unload netback module.
> [...]
> > diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c
> > index 26af7b7..dd10c0d 100644
> > --- a/drivers/net/xen-netback/netback.c
> > +++ b/drivers/net/xen-netback/netback.c
> > @@ -1653,5 +1653,19 @@ failed_init:
> >
> > module_init(netback_init);
> >
> > +static void __exit netback_exit(void)
> > +{
> > + int i;
> > + for (i = 0; i < xen_netbk_group_nr; i++) {
> > + struct xen_netbk *netbk = &xen_netbk[i];
> > + del_timer(&netbk->net_timer);
>
> This needs to be del_timer_sync().
>
> > + kthread_stop(netbk->task);
> > + }
> > + vfree(xen_netbk);
> > + page_pool_destroy();
> > + xenvif_xenbus_exit();
> > +}
Both fixed.
Thanks
Wei.
next prev parent reply other threads:[~2012-01-16 9:32 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-13 16:59 [RFC PATCH] New Xen netback implementation Wei Liu
2012-01-13 16:59 ` [RFC PATCH 1/6] netback: page pool version 1 Wei Liu
2012-01-13 17:37 ` Konrad Rzeszutek Wilk
2012-01-16 9:31 ` Wei Liu
2012-01-13 16:59 ` [RFC PATCH 2/6] netback: add module unload function Wei Liu
2012-01-13 17:57 ` [Xen-devel] " David Vrabel
2012-01-16 9:31 ` Wei Liu [this message]
2012-01-13 18:47 ` David Vrabel
2012-01-13 16:59 ` [RFC PATCH 3/6] netback: switch to NAPI + kthread model Wei Liu
2012-01-13 18:21 ` [Xen-devel] " David Vrabel
2012-01-16 9:33 ` Wei Liu
2012-01-16 10:45 ` Ian Campbell
2012-01-16 10:49 ` Wei Liu
2012-01-16 10:56 ` Paul Durrant
2012-01-16 11:09 ` Ian Campbell
2012-01-16 11:46 ` David Vrabel
2012-01-16 10:14 ` Paul Durrant
2012-01-16 10:31 ` Ian Campbell
2012-01-13 16:59 ` [RFC PATCH 4/6] netback: add module get/put operations along with vif connect/disconnect Wei Liu
2012-01-13 18:44 ` [Xen-devel] " David Vrabel
2012-01-16 9:43 ` Wei Liu
2012-01-13 16:59 ` [RFC PATCH 5/6] netback: melt xen_netbk into xenvif Wei Liu
2012-01-13 16:59 ` [RFC PATCH 6/6] netback: alter internal function/structure names Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1326706318.5285.4.camel@liuw-desktop \
--to=wei.liu2@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=dvrabel@cantab.net \
--cc=konrad.wilk@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).