From: Wei Liu <wei.liu2@citrix.com>
To: ian.campbell@citrix.com, netdev@vger.kernel.org,
xen-devel@lists.xensource.com
Cc: konrad.wilk@oracle.com, david.vrabel@citrix.com,
paul.durrant@citrix.com, Wei Liu <wei.liu2@citrix.com>
Subject: [RFC PATCH V2 5/8] netback: add module get/put operations along with vif connect/disconnect.
Date: Tue, 17 Jan 2012 13:47:01 +0000 [thread overview]
Message-ID: <1326808024-3744-6-git-send-email-wei.liu2@citrix.com> (raw)
In-Reply-To: <1326808024-3744-1-git-send-email-wei.liu2@citrix.com>
If there is vif running and user unloads netback, it will certainly
cause problems -- guest's network interface just mysteriously stops
working.
Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
drivers/net/xen-netback/interface.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c
index dfc04f8..7c86187 100644
--- a/drivers/net/xen-netback/interface.c
+++ b/drivers/net/xen-netback/interface.c
@@ -323,6 +323,8 @@ int xenvif_connect(struct xenvif *vif, unsigned long tx_ring_ref,
if (vif->irq)
return 0;
+ __module_get(THIS_MODULE);
+
err = xen_netbk_map_frontend_rings(vif, tx_ring_ref, rx_ring_ref);
if (err < 0)
goto err;
@@ -405,4 +407,6 @@ void xenvif_disconnect(struct xenvif *vif)
xen_netbk_unmap_frontend_rings(vif);
free_netdev(vif->dev);
+
+ module_put(THIS_MODULE);
}
--
1.7.2.5
next prev parent reply other threads:[~2012-01-17 13:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-17 13:46 [RFC PATCH V2] New Xen netback implementation Wei Liu
2012-01-17 13:46 ` [RFC PATCH V2 1/8] netback: page pool version 1 Wei Liu
2012-01-17 13:46 ` [RFC PATCH V2 2/8] netback: add module unload function Wei Liu
2012-01-17 13:46 ` [RFC PATCH V2 3/8] netback: switch to NAPI + kthread model Wei Liu
2012-01-17 17:07 ` Stephen Hemminger
2012-01-17 17:11 ` Wei Liu
2012-01-17 13:47 ` [RFC PATCH V2 4/8] netback: switch to per-cpu scratch space Wei Liu
2012-01-17 13:47 ` Wei Liu [this message]
2012-01-17 13:47 ` [RFC PATCH V2 6/8] netback: melt xen_netbk into xenvif Wei Liu
2012-01-17 13:47 ` [RFC PATCH V2 7/8] netback: alter internal function/structure names Wei Liu
2012-01-17 13:47 ` [RFC PATCH V2 8/8] netback: remove unwanted notification generation during NAPI processing Wei Liu
2012-01-27 19:22 ` [RFC PATCH V2] New Xen netback implementation Konrad Rzeszutek Wilk
2012-01-29 13:42 ` Wei Liu
2012-01-29 21:37 ` Konrad Rzeszutek Wilk
2012-01-30 15:01 ` Wei Liu
2012-01-30 18:27 ` Wei Liu
2012-01-30 18:30 ` Wei Liu
2012-01-30 19:41 ` Wei Liu
2012-01-30 15:07 ` Ian Campbell
2012-01-30 15:21 ` Konrad Rzeszutek Wilk
2012-01-30 15:49 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1326808024-3744-6-git-send-email-wei.liu2@citrix.com \
--to=wei.liu2@citrix.com \
--cc=david.vrabel@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=paul.durrant@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).