From: Eric Dumazet <eric.dumazet@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
James Morris <jmorris@namei.org>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Patrick McHardy <kaber@trash.net>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] inetpeer: initialize ->redirect_genid in inet_getpeer()
Date: Tue, 17 Jan 2012 21:57:08 +0100 [thread overview]
Message-ID: <1326833828.2606.5.camel@edumazet-laptop> (raw)
In-Reply-To: <20120117204843.GA20999@elgon.mountain>
Le mardi 17 janvier 2012 à 23:48 +0300, Dan Carpenter a écrit :
> kmemcheck complains that ->redirect_genid doesn't get initialized.
> Presumably it should be set to zero.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/net/ipv4/inetpeer.c b/net/ipv4/inetpeer.c
> index 86f13c67..49ce5f4 100644
> --- a/net/ipv4/inetpeer.c
> +++ b/net/ipv4/inetpeer.c
> @@ -447,6 +447,7 @@ relookup:
> p->rate_last = 0;
> p->pmtu_expires = 0;
> p->pmtu_orig = 0;
> + p->redirect_genid = 0;
> memset(&p->redirect_learned, 0, sizeof(p->redirect_learned));
>
>
We dont really care, since we force redirect_learned.a4 to be 0
Only place we care is in ip_rt_redirect() and its done properly there.
Lets shutup kmemcheck.
Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
prev parent reply other threads:[~2012-01-17 20:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-17 20:48 [patch] inetpeer: initialize ->redirect_genid in inet_getpeer() Dan Carpenter
2012-01-17 20:52 ` David Miller
2012-01-17 20:58 ` Eric Dumazet
2012-01-17 20:57 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1326833828.2606.5.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).