From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: Stephen Hemminger <shemminger@vyatta.com>,
netdev@vger.kernel.org, gospo@redhat.com, sassmann@redhat.com,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net 3/9] igbvf: remove unneeded cast
Date: Thu, 19 Jan 2012 00:13:28 -0800 [thread overview]
Message-ID: <1326960814-16976-4-git-send-email-jeffrey.t.kirsher@intel.com> (raw)
In-Reply-To: <1326960814-16976-1-git-send-email-jeffrey.t.kirsher@intel.com>
From: Stephen Hemminger <shemminger@vyatta.com>
The cast and comment are unnecessary in the current upstream kernel.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Tested-by: Garrett, RobertX E <robertx.e.garrett@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/ethernet/intel/igbvf/ethtool.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/igbvf/ethtool.c b/drivers/net/ethernet/intel/igbvf/ethtool.c
index 7b600a1..2dba534 100644
--- a/drivers/net/ethernet/intel/igbvf/ethtool.c
+++ b/drivers/net/ethernet/intel/igbvf/ethtool.c
@@ -468,6 +468,5 @@ static const struct ethtool_ops igbvf_ethtool_ops = {
void igbvf_set_ethtool_ops(struct net_device *netdev)
{
- /* have to "undeclare" const on this struct to remove warnings */
- SET_ETHTOOL_OPS(netdev, (struct ethtool_ops *)&igbvf_ethtool_ops);
+ SET_ETHTOOL_OPS(netdev, &igbvf_ethtool_ops);
}
--
1.7.7.5
next prev parent reply other threads:[~2012-01-19 8:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-19 8:13 [net 0/9][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2012-01-19 8:13 ` [net 1/9] igb: make local functions static Jeff Kirsher
2012-01-19 8:13 ` [net 2/9] igb: Update Copyright on all Intel copyrighted files Jeff Kirsher
2012-01-19 8:13 ` Jeff Kirsher [this message]
2012-01-19 8:13 ` [net 4/9] igbvf: Remove unnecessary irq disable/enable Jeff Kirsher
2012-01-19 8:13 ` [net 5/9] ixgbe: Fix register defines to correctly handle complex expressions Jeff Kirsher
2012-01-19 8:13 ` [net 6/9] ixgbevf: Prevent possible race condition by checking for message Jeff Kirsher
2012-01-19 8:13 ` [net 7/9] ixgbevf: make ethtool ops and strings const Jeff Kirsher
2012-01-19 8:13 ` [net 8/9] ixgbevf: fix sparse warnings Jeff Kirsher
2012-01-19 8:13 ` [net 9/9] ixgbevf: make operations tables const Jeff Kirsher
2012-01-19 17:51 ` [net 0/9][pull request] Intel Wired LAN Driver Updates David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1326960814-16976-4-git-send-email-jeffrey.t.kirsher@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).