netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: Mitch A Williams <mitch.a.williams@intel.com>,
	netdev@vger.kernel.org, gospo@redhat.com, sassmann@redhat.com,
	Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net 4/9] igbvf: Remove unnecessary irq disable/enable
Date: Thu, 19 Jan 2012 00:13:29 -0800	[thread overview]
Message-ID: <1326960814-16976-5-git-send-email-jeffrey.t.kirsher@intel.com> (raw)
In-Reply-To: <1326960814-16976-1-git-send-email-jeffrey.t.kirsher@intel.com>

From: Mitch A Williams <mitch.a.williams@intel.com>

This irq disable/enable pair used to wrap access to the driver's vlgrp
struct, which is no longer present. So, then, this could also so no longer
be present.

Signed-off-by: Mitch Williams <mitch.a.williams@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
 drivers/net/ethernet/intel/igbvf/netdev.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/drivers/net/ethernet/intel/igbvf/netdev.c b/drivers/net/ethernet/intel/igbvf/netdev.c
index fd3da30..a4b20c8 100644
--- a/drivers/net/ethernet/intel/igbvf/netdev.c
+++ b/drivers/net/ethernet/intel/igbvf/netdev.c
@@ -1194,11 +1194,6 @@ static int igbvf_vlan_rx_kill_vid(struct net_device *netdev, u16 vid)
 	struct igbvf_adapter *adapter = netdev_priv(netdev);
 	struct e1000_hw *hw = &adapter->hw;
 
-	igbvf_irq_disable(adapter);
-
-	if (!test_bit(__IGBVF_DOWN, &adapter->state))
-		igbvf_irq_enable(adapter);
-
 	if (hw->mac.ops.set_vfta(hw, vid, false)) {
 		dev_err(&adapter->pdev->dev,
 		        "Failed to remove vlan id %d\n", vid);
-- 
1.7.7.5

  parent reply	other threads:[~2012-01-19  8:13 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-19  8:13 [net 0/9][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2012-01-19  8:13 ` [net 1/9] igb: make local functions static Jeff Kirsher
2012-01-19  8:13 ` [net 2/9] igb: Update Copyright on all Intel copyrighted files Jeff Kirsher
2012-01-19  8:13 ` [net 3/9] igbvf: remove unneeded cast Jeff Kirsher
2012-01-19  8:13 ` Jeff Kirsher [this message]
2012-01-19  8:13 ` [net 5/9] ixgbe: Fix register defines to correctly handle complex expressions Jeff Kirsher
2012-01-19  8:13 ` [net 6/9] ixgbevf: Prevent possible race condition by checking for message Jeff Kirsher
2012-01-19  8:13 ` [net 7/9] ixgbevf: make ethtool ops and strings const Jeff Kirsher
2012-01-19  8:13 ` [net 8/9] ixgbevf: fix sparse warnings Jeff Kirsher
2012-01-19  8:13 ` [net 9/9] ixgbevf: make operations tables const Jeff Kirsher
2012-01-19 17:51 ` [net 0/9][pull request] Intel Wired LAN Driver Updates David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1326960814-16976-5-git-send-email-jeffrey.t.kirsher@intel.com \
    --to=jeffrey.t.kirsher@intel.com \
    --cc=davem@davemloft.net \
    --cc=gospo@redhat.com \
    --cc=mitch.a.williams@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=sassmann@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).