From: Eric Dumazet <eric.dumazet@gmail.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH 3/3] skge: add byte queue limit support
Date: Fri, 20 Jan 2012 07:23:44 +0100 [thread overview]
Message-ID: <1327040624.4826.10.camel@edumazet-laptop> (raw)
In-Reply-To: <20120119164354.78ea63d6@nehalam.linuxnetplumber.net>
Le jeudi 19 janvier 2012 à 16:43 -0800, Stephen Hemminger a écrit :
> This also changes the cleanup logic slightly to aggregate
> completed notifications for multiple packets.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
>
> --- a/drivers/net/ethernet/marvell/skge.c 2012-01-19 16:12:19.000000000 -0800
> +++ b/drivers/net/ethernet/marvell/skge.c 2012-01-19 16:42:17.675908798 -0800
> @@ -2831,6 +2831,7 @@ static netdev_tx_t skge_xmit_frame(struc
> netif_stop_queue(dev);
> }
>
> + netdev_sent_queue(dev, skb->len);
I doubt this is safe, as skb might already be freed by tx completion
handler from another cpu.
> return NETDEV_TX_OK;
>
> mapping_unwind:
> @@ -2858,11 +2859,9 @@ mapping_error:
>
>
next prev parent reply other threads:[~2012-01-20 6:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-20 0:43 [PATCH 3/3] skge: add byte queue limit support Stephen Hemminger
2012-01-20 6:23 ` Eric Dumazet [this message]
2012-01-22 19:25 ` David Miller
2012-01-22 19:40 ` Stephen Hemminger
2012-01-23 15:48 ` Eric Dumazet
2012-01-23 19:25 ` David Miller
2012-01-22 19:24 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1327040624.4826.10.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox