From: Joe Perches <joe@perches.com>
To: "Pradeep A. Dalvi" <netdev@pradeepdalvi.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Christoph Hellwig <hch@lst.de>,
linux-kernel@vger.kernel.org,
Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH/RESEND] drivers/net/ethernet: dev_alloc_skb to netdev_alloc_skb
Date: Mon, 23 Jan 2012 11:56:01 -0800 [thread overview]
Message-ID: <1327348561.7527.0.camel@joe2Laptop> (raw)
In-Reply-To: <CA+Dx6HY92Z8KtDXf73O3QMWLj__+Q2g7PxjiZ7omn+tuh8YK5A@mail.gmail.com>
On Tue, 2012-01-24 at 00:49 +0530, Pradeep A. Dalvi wrote:
> On Tue, Jan 24, 2012 at 12:10 AM, Joe Perches <joe@perches.com> wrote:
> > On Mon, 2012-01-23 at 23:58 +0530, Pradeep A. Dalvi wrote:
> >> Replaced deprecating dev_alloc_skb with netdev_alloc_skb in drivers/net/ethernet
> >> - Removed extra skb->dev = dev after netdev_alloc_skb
> > []
> >> diff --git a/drivers/net/ethernet/amd/lance.c b/drivers/net/ethernet/amd/lance.c
> > []
> >> @@ -871,13 +871,12 @@ lance_init_ring(struct net_device *dev, gfp_t gfp)
> >> struct sk_buff *skb;
> >> void *rx_buff;
> >>
> >> - skb = alloc_skb(PKT_BUF_SZ, GFP_DMA | gfp);
> >> + skb = netdev_alloc_skb(dev, PKT_BUF_SZ);
> >
> > This change seems suspect.
> Not really sure what made you suspect something in here. If you could
> help me understand possibly broken scenarios, would essentially be
> helpful. Thanks in advance!
Where did the GFP_DMA go?
next prev parent reply other threads:[~2012-01-23 19:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-23 18:28 [PATCH/RESEND] drivers/net/ethernet: dev_alloc_skb to netdev_alloc_skb Pradeep A. Dalvi
2012-01-23 18:40 ` Joe Perches
2012-01-23 18:53 ` David Miller
2012-01-23 19:13 ` Pradeep A. Dalvi
2012-01-23 19:23 ` David Miller
2012-01-23 19:37 ` Pradeep A. Dalvi
2012-01-23 19:19 ` Pradeep A. Dalvi
2012-01-23 19:56 ` Joe Perches [this message]
2012-01-23 20:41 ` Pradeep A. Dalvi
2012-01-23 20:46 ` Joe Perches
2012-01-23 21:15 ` Eric Dumazet
2012-01-23 21:53 ` David Miller
2012-01-23 23:04 ` Pradeep A. Dalvi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1327348561.7527.0.camel@joe2Laptop \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@pradeepdalvi.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).