From: Eric Dumazet <eric.dumazet@gmail.com>
To: "Pradeep A. Dalvi" <netdev@pradeepdalvi.com>
Cc: Joe Perches <joe@perches.com>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Christoph Hellwig <hch@lst.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH/RESEND] drivers/net/ethernet: dev_alloc_skb to netdev_alloc_skb
Date: Mon, 23 Jan 2012 22:15:39 +0100 [thread overview]
Message-ID: <1327353339.2587.7.camel@edumazet-laptop> (raw)
In-Reply-To: <CA+Dx6HbxEFLTMMGJ-ASY=4zNthRtWps6KnFiPNLAz6o+HVmS9g@mail.gmail.com>
Le mardi 24 janvier 2012 à 02:11 +0530, Pradeep A. Dalvi a écrit :
> Aah! Is that really needed? Cause from my understanding, priority GFP
> flag __GFP_DMA is anyway negated in __alloc_skb, in a way from all
> sources i.e. netdev_alloc_skb or dev_alloc_skb or even alloc_skb. Am I
> missing something here?
You should read the whole __alloc_skb() function and not only half of
it.
skb itself is allocated in the normal memory pool, (not GFP_DMA), since
it has no hardware requirement for a kernel structure.
But skb->head _is_ allocated with GFP_DMA if driver requested it.
next prev parent reply other threads:[~2012-01-23 21:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-23 18:28 [PATCH/RESEND] drivers/net/ethernet: dev_alloc_skb to netdev_alloc_skb Pradeep A. Dalvi
2012-01-23 18:40 ` Joe Perches
2012-01-23 18:53 ` David Miller
2012-01-23 19:13 ` Pradeep A. Dalvi
2012-01-23 19:23 ` David Miller
2012-01-23 19:37 ` Pradeep A. Dalvi
2012-01-23 19:19 ` Pradeep A. Dalvi
2012-01-23 19:56 ` Joe Perches
2012-01-23 20:41 ` Pradeep A. Dalvi
2012-01-23 20:46 ` Joe Perches
2012-01-23 21:15 ` Eric Dumazet [this message]
2012-01-23 21:53 ` David Miller
2012-01-23 23:04 ` Pradeep A. Dalvi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1327353339.2587.7.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=hch@lst.de \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@pradeepdalvi.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox