netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Flavio Leitner <fbl@redhat.com>
To: netdev <netdev@vger.kernel.org>
Cc: Marcelo Leitner <mleitner@redhat.com>,
	Eric Dumazet <eric.dumazet@gmail.com>,
	Flavio Leitner <fbl@redhat.com>
Subject: [PATCH 1/2] tcp: bind() fix autoselection to share ports
Date: Wed, 25 Jan 2012 16:34:51 -0200	[thread overview]
Message-ID: <1327516492-9045-1-git-send-email-fbl@redhat.com> (raw)

The current code checks for conflicts when the application
requests a specific port.  If there is no conflict, then
the request is granted.

On the other hand, the port autoselection done by the kernel
fails when all ports are bound even when there is a port
with no conflict available.

The fix changes port autoselection to check if there is a
conflict and use it if not.

Signed-off-by: Flavio Leitner <fbl@redhat.com>
---
 net/ipv4/inet_connection_sock.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/net/ipv4/inet_connection_sock.c b/net/ipv4/inet_connection_sock.c
index 2e4e244..ecd19b5 100644
--- a/net/ipv4/inet_connection_sock.c
+++ b/net/ipv4/inet_connection_sock.c
@@ -128,6 +128,11 @@ again:
 							goto have_snum;
 						}
 					}
+					if (!inet_csk(sk)->icsk_af_ops->bind_conflict(sk, tb)) {
+						spin_unlock(&head->lock);
+						snum = rover;
+						goto have_snum;
+					}
 					goto next;
 				}
 			break;
-- 
1.7.7.1

             reply	other threads:[~2012-01-25 18:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-25 18:34 Flavio Leitner [this message]
2012-01-25 18:34 ` [PATCH 2/2] tcp: bind() optimize port allocation Flavio Leitner
2012-01-25 18:36   ` Marcelo Leitner
2012-01-25 18:48   ` Eric Dumazet
2012-01-26  2:51   ` David Miller
2012-01-25 18:36 ` [PATCH 1/2] tcp: bind() fix autoselection to share ports Marcelo Leitner
2012-01-25 18:47 ` Eric Dumazet
2012-01-26  2:50 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1327516492-9045-1-git-send-email-fbl@redhat.com \
    --to=fbl@redhat.com \
    --cc=eric.dumazet@gmail.com \
    --cc=mleitner@redhat.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).