From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Richard Cochran <richardcochran@gmail.com>,
"Brown, Aaron F" <aaron.f.brown@intel.com>,
netdev@vger.kernel.org, e1000-devel@lists.sourceforge.net,
Jacob Keller <jacob.e.keller@intel.com>,
John Ronciak <john.ronciak@intel.com>,
John Stultz <john.stultz@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH net V4 0/2] igb: ptp hardware clock
Date: Fri, 27 Jan 2012 02:56:29 -0800 [thread overview]
Message-ID: <1327661789.2729.57.camel@jtkirshe-mobl> (raw)
In-Reply-To: <1327659761.2220.0.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
[-- Attachment #1: Type: text/plain, Size: 1570 bytes --]
On Fri, 2012-01-27 at 11:22 +0100, Eric Dumazet wrote:
> Le vendredi 27 janvier 2012 à 02:15 -0800, Jeff Kirsher a écrit :
> > On Fri, 2012-01-27 at 11:11 +0100, Richard Cochran wrote:
> > > On Thu, Jan 26, 2012 at 08:24:53PM -0800, Jeff Kirsher wrote:
> > > > Richard-
> > > >
> > > > Did you compile test? Why I ask is our validation team is getting the
> > > > following errors when trying to compile in PTP support:
> > >
> > > I did compile and also tested the driver.
> > >
> > > What .config are you using? What kernel version?
> > >
> > > Thanks,
> > > Richard
> >
> > I will have Aaron post his .config's that he tried. I know that he
> > tried multiple configs with no success. As far as kernel version, he
> > was using the latest net-next tree from David Miller.
>
> This might coming from
>
> commit 36a1211970193ce215de50ed1e4e1272bc814df1
> Author: Paul Gortmaker <paul.gortmaker@windriver.com>
> Date: Tue Jan 24 11:33:19 2012 +0000
>
> netprio_cgroup.h: dont include module.h from other includes
>
> A considerable effort was invested in wiping out module.h
> from being present in all the other standard includes. This
> one leaked back in, but once again isn't strictly necessary,
> so remove it.
>
>
>
Eric was correct. I added #include <linux/mdoule.h> to the igb_ptp.c
file and the error goes away.
Richard are you fine with me adding that change to your first patch of
the series? That way I can have the validation team finish up testing
your patches.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-01-27 10:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-21 16:03 [PATCH net V4 0/2] igb: ptp hardware clock Richard Cochran
2012-01-21 16:03 ` [PATCH net V4 1/2] igb: add PTP Hardware Clock code Richard Cochran
2012-01-23 18:39 ` Keller, Jacob E
2012-01-24 17:44 ` Richard Cochran
2012-01-24 21:23 ` Keller, Jacob E
2012-01-27 19:25 ` Keller, Jacob E
2012-01-21 16:03 ` [PATCH net V4 2/2] igb: offer a PTP Hardware Clock instead of the timecompare method Richard Cochran
2012-01-23 3:57 ` [PATCH net V4 0/2] igb: ptp hardware clock Jeff Kirsher
2012-01-27 4:24 ` Jeff Kirsher
2012-01-27 10:11 ` Richard Cochran
2012-01-27 10:15 ` Jeff Kirsher
2012-01-27 10:22 ` Eric Dumazet
2012-01-27 10:56 ` Jeff Kirsher [this message]
2012-01-27 12:11 ` Richard Cochran
2012-01-27 20:42 ` Brown, Aaron F
2012-01-28 8:26 ` Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1327661789.2729.57.camel@jtkirshe-mobl \
--to=jeffrey.t.kirsher@intel.com \
--cc=aaron.f.brown@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=eric.dumazet@gmail.com \
--cc=jacob.e.keller@intel.com \
--cc=john.ronciak@intel.com \
--cc=john.stultz@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).