From: Joe Perches <joe@perches.com>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
Hayes Wang <hayeswang@realtek.com>
Subject: Re: [PATCH net-next 3/7] r8169: stop delaying workqueue.
Date: Fri, 27 Jan 2012 13:20:13 -0800 [thread overview]
Message-ID: <1327699213.19848.5.camel@joe2Laptop> (raw)
In-Reply-To: <20120127205632.GC24507@electric-eye.fr.zoreil.com>
On Fri, 2012-01-27 at 21:56 +0100, Francois Romieu wrote:
> Though motivated by the move of the driver to a single work queue of
> sequential events and removal of hard irq processing, it looks safe as
> a standalone change.
[]
> diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
[]
> @@ -714,7 +714,11 @@ struct rtl8169_private {
> unsigned int (*phy_reset_pending)(struct rtl8169_private *tp);
> unsigned int (*link_ok)(void __iomem *);
> int (*do_ioctl)(struct rtl8169_private *tp, struct mii_ioctl_data *data, int cmd);
> - struct delayed_work task;
> +
> + struct {
> + struct work_struct work;
> + } wk;
This struct is usefully expanded in patch 7/7.
Perhaps this should be mentioned in the changelog
otherwise the change looks rather suspect.
next prev parent reply other threads:[~2012-01-27 21:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-27 20:54 [PATCH net-next 0/7] Pull request for r8169 branch Francois Romieu
2012-01-27 20:54 ` [PATCH net-next 1/7] r8169: remove hardcoded PCIe registers accesses Francois Romieu
2012-01-27 20:55 ` [PATCH net-next 2/7] r8169: remove rtl8169_reinit_task Francois Romieu
2012-01-27 20:56 ` [PATCH net-next 3/7] r8169: stop delaying workqueue Francois Romieu
2012-01-27 21:20 ` Joe Perches [this message]
2012-01-27 20:56 ` [PATCH net-next 4/7] r8169: factor out IntrMask writes Francois Romieu
2012-01-27 20:57 ` [PATCH net-next 5/7] r8169: irq mask helpers Francois Romieu
2012-01-27 20:58 ` [PATCH net-next 6/7] r8169: missing barriers Francois Romieu
2012-01-28 9:06 ` Eric Dumazet
2012-01-28 12:07 ` Francois Romieu
2012-01-27 20:59 ` [PATCH net-next 7/7] r8169: remove work from irq handler Francois Romieu
2012-01-28 5:41 ` Michał Mirosław
2012-01-28 8:39 ` Francois Romieu
2012-01-28 9:11 ` Michał Mirosław
2012-01-28 9:36 ` Michał Mirosław
2012-01-28 11:11 ` Francois Romieu
2012-01-28 12:12 ` Michał Mirosław
2012-01-30 17:39 ` [PATCH net-next 0/7] Pull request for r8169 branch David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1327699213.19848.5.camel@joe2Laptop \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=hayeswang@realtek.com \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox