From: Eric Dumazet <eric.dumazet@gmail.com>
To: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: Ben Hutchings <bhutchings@solarflare.com>, netdev@vger.kernel.org
Subject: Re: [RFC PATCH v2] ethtool: implement [GS]FEATURES handling
Date: Sat, 28 Jan 2012 11:02:02 +0100 [thread overview]
Message-ID: <1327744922.7199.3.camel@edumazet-laptop> (raw)
In-Reply-To: <08e06fc4d7b6e4dba466422a7cc93b2e2630c978.1327739670.git.mirq-linux@rere.qmqm.pl>
Le samedi 28 janvier 2012 à 09:37 +0100, Michał Mirosław a écrit :
> v2: fix missing change CMDL_FLAG -> CMDL_BOOL for old offloads parsing
>
> Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
> ---
> ethtool.c | 613 ++++++++++++++++++++++++++++++++++++++++++++++++------------
> 1 files changed, 490 insertions(+), 123 deletions(-)
Seems fine to me, here is the result for the new section :
I can now 'see' my tg3 doesnt support tx-tcp6-segmentation without
having to read driver source...
Extended offload state for eth3:
tx-scatter-gather: on (changeable)
tx-checksum-ipv4: on (changeable)
tx-checksum-ip-generic: off (driver-controlled)
tx-checksum-ipv6: off (driver-controlled)
highdma: on (changeable)
tx-scatter-gather-fraglist: off (driver-controlled)
tx-vlan-hw-insert: on (changeable)
rx-vlan-hw-parse: on (changeable)
rx-vlan-filter: off (driver-controlled)
vlan-challenged: off (fixed)
tx-generic-segmentation: on (changeable)
tx-lockless: off (fixed)
netns-local: off (fixed)
rx-gro: on (changeable)
rx-lro: off (driver-controlled)
tx-tcp-segmentation: on (changeable)
tx-udp-fragmentation: off (driver-controlled)
tx-gso-robust: off (driver-controlled)
tx-tcp-ecn-segmentation: off (driver-controlled)
tx-tcp6-segmentation: off (driver-controlled)
tx-fcoe-segmentation: off (driver-controlled)
tx-checksum-fcoe-crc: off (driver-controlled)
tx-checksum-sctp: off (driver-controlled)
fcoe-mtu: off (driver-controlled)
rx-ntuple-filter: off (driver-controlled)
rx-hashing: off (driver-controlled)
rx-checksum: on (changeable)
tx-nocache-copy: on (changeable)
loopback: off (changeable)
Thanks !
next prev parent reply other threads:[~2012-01-28 10:02 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-03 14:21 [PATCH v4 0/5] net: Unified offload configuration Michał Mirosław
2011-02-03 14:21 ` [PATCH v4 3/5] net: use ndo_fix_features for ethtool_ops->set_flags Michał Mirosław
2011-02-07 19:46 ` Ben Hutchings
2011-02-07 21:03 ` David Miller
2011-02-03 14:21 ` [PATCH v4 2/5] net: ethtool: use ndo_fix_features for offload setting Michał Mirosław
2011-02-07 21:01 ` David Miller
2011-02-03 14:21 ` [PATCH v4 1/5] net: Introduce new feature setting ops Michał Mirosław
2011-02-07 19:39 ` Ben Hutchings
2011-02-07 20:51 ` David Miller
2011-02-07 20:55 ` David Miller
2012-01-24 13:54 ` Eric Dumazet
2012-01-24 15:30 ` Ben Hutchings
2012-01-24 15:47 ` Eric Dumazet
2012-01-24 19:05 ` Michał Mirosław
2012-01-28 8:30 ` [RFC PATCH] ethtool: implement [GS]FEATURES handling Michał Mirosław
2012-01-28 8:37 ` [RFC PATCH v2] " Michał Mirosław
2012-01-28 10:02 ` Eric Dumazet [this message]
2011-02-03 14:21 ` [PATCH v4 4/5] net: introduce NETIF_F_RXCSUM Michał Mirosław
2011-02-07 21:12 ` David Miller
2011-02-03 14:21 ` [PATCH v2] ethtool: implement G/SFEATURES calls Michał Mirosław
2011-02-03 14:21 ` [PATCH v4 5/5] loopback: convert to hw_features Michał Mirosław
2011-02-07 21:18 ` David Miller
2011-02-07 21:37 ` [PATCH v4 0/5] net: Unified offload configuration David Miller
2011-02-07 22:49 ` Michał Mirosław
2011-02-07 22:52 ` David Miller
2011-02-07 23:12 ` Michał Mirosław
2011-02-08 19:40 ` David Miller
2011-02-08 23:55 ` Michał Mirosław
2011-02-08 23:58 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1327744922.7199.3.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=bhutchings@solarflare.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox