From: Joe Perches <joe@perches.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: "Devendra.Naga" <devendra.aaru@gmail.com>,
chaoming_li@realsil.com.cn, linville@tuxdriver.com,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] wireless: remove return in _rtl_pci_switch_clk_req
Date: Mon, 30 Jan 2012 15:45:03 -0800 [thread overview]
Message-ID: <1327967103.4230.7.camel@joe2Laptop> (raw)
In-Reply-To: <4F27294D.30302@lwfinger.net>
On Mon, 2012-01-30 at 17:35 -0600, Larry Finger wrote:
> The patch is OK, but the patch subject is bad. You should have "[PATCH]
> rtlwifi:...". Your patch is for rtlwifi, not wireless.
Hi Devendra.
A reasonable rule of thumb is use the deepest directory
path basename you can to prefix the patch.
Something like:
[PATCH] $(basename $(dirname $file)): terse description
If you are patching drivers/net/ethernet/realtek/apt.c
this becomes:
[PATCH] realtek: terse description
There are some exceptions though. One of them
is if the patch is in staging, prefix with
[PATCH] staging: $(basename $(dirname $file)): description
cheers, Joe
next prev parent reply other threads:[~2012-01-30 23:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-30 12:46 [PATCH 1/1] wireless: remove return in _rtl_pci_switch_clk_req Devendra.Naga
2012-01-30 23:35 ` Larry Finger
2012-01-30 23:45 ` Joe Perches [this message]
2012-01-31 6:22 ` devendra.aaru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1327967103.4230.7.camel@joe2Laptop \
--to=joe@perches.com \
--cc=Larry.Finger@lwfinger.net \
--cc=chaoming_li@realsil.com.cn \
--cc=devendra.aaru@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).