From: Eric Dumazet <eric.dumazet@gmail.com>
To: Shawn Lu <shawn.lu@ericsson.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"xiaoclu@gmail.com" <xiaoclu@gmail.com>
Subject: Re: [PATCH net-next] tcp: md5: rcu conversion
Date: Tue, 31 Jan 2012 16:38:37 +0100 [thread overview]
Message-ID: <1328024317.2297.31.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC> (raw)
In-Reply-To: <1328023113.2297.23.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
Le mardi 31 janvier 2012 à 16:18 +0100, Eric Dumazet a écrit :
> In order to be able to support proper RST messages for TCP MD5 flows, we
> need to allow access to MD5 keys without locking listener socket.
>
> This conversion is a nice cleanup, and shrinks size of timewait sockets
> by 80 bytes.
>
> IPv6 code reuses generic code found in IPv4 instead of duplicating it.
>
> Control path uses GFP_KERNEL allocations instead of GFP_ATOMIC.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
> Cc: Shawn Lu <shawn.lu@ericsson.com>
By the way, we probably need to add a limit on the number of keys a
socket can store. It seems previous code relied on kmalloc(big_array)
limits (~4MB on x86) only.
sock_kmalloc() might be the right thing to use instead of kmalloc()
next prev parent reply other threads:[~2012-01-31 15:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-31 2:07 [PATCH] tcp: md5: fix md5 RST when both sides have listener Shawn Lu
2012-01-31 2:16 ` Eric Dumazet
2012-01-31 2:37 ` Shawn Lu
2012-01-31 8:39 ` Shawn Lu
2012-01-31 9:05 ` Eric Dumazet
2012-01-31 13:33 ` Eric Dumazet
2012-01-31 15:18 ` [PATCH net-next] tcp: md5: rcu conversion Eric Dumazet
2012-01-31 15:38 ` Eric Dumazet [this message]
2012-01-31 17:15 ` David Miller
2012-01-31 20:56 ` [PATCH net-next] tcp: md5: use sock_kmalloc() to limit md5 keys Eric Dumazet
2012-01-31 21:13 ` David Miller
2012-01-31 17:14 ` [PATCH net-next] tcp: md5: rcu conversion David Miller
2012-01-31 18:15 ` [PATCH] tcp: md5: fix md5 RST when both sides have listener Shawn Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1328024317.2297.31.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shawn.lu@ericsson.com \
--cc=xiaoclu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox