From: Joe Perches <joe@perches.com>
To: Karsten Keil <kkeil@linux-pingi.de>
Cc: geunsik.lim@gmail.com, David Miller <davem@davemloft.net>,
isdn@linux-pingi.de, lucas.demarchi@profusion.mobi,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Keep kernel coding style rule of hfs-s+/sp source
Date: Thu, 02 Feb 2012 11:11:59 -0800 [thread overview]
Message-ID: <1328209919.18641.42.camel@joe2Laptop> (raw)
In-Reply-To: <20120202190152.GB11660@gw.linux-pingi.de>
On Thu, 2012-02-02 at 20:01 +0100, Karsten Keil wrote:
> > >> This was probably there to eliminate compiler warnings or avoid the
> Yes it was.
[]
> I think in this case a coding style violation is minor to a warning or
> potencial miscompiling.
> Do not misunderstand me that I do not like to make the code better and more
> readable, but such small style violations should be only fixed when here is
> a strong need or the driver is reworked in bigger parts and full testing
> is done.
I agree, but in the future (or perhaps even today)
it's better to mark these odd coding style uses with
macros to indicate the reason for their use.
Perhaps something akin to the ACCESS_ONCE macro like
#define PERFORM_ONCE(expr) \
do { \
if ((expr)) \
; \
} while (0)
prev parent reply other threads:[~2012-02-02 19:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-01 6:59 [PATCH] Keep kernel coding style rule of hfs-s+/sp source Geunsik Lim
2012-02-01 7:06 ` David Miller
[not found] ` <CAGFP0LKU0uDPQzhCy8qmThXQ9f9ofSnQrbr2dO83i+usc85_FQ@mail.gmail.com>
2012-02-01 7:48 ` David Miller
2012-02-02 19:01 ` Karsten Keil
2012-02-02 19:11 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1328209919.18641.42.camel@joe2Laptop \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=geunsik.lim@gmail.com \
--cc=isdn@linux-pingi.de \
--cc=kkeil@linux-pingi.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.demarchi@profusion.mobi \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox