From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, gospo@redhat.com, sassmann@redhat.com
Subject: Re: [net 4/8] ixgbe: fix namespace issues when FCoE is not enabled
Date: Thu, 02 Feb 2012 21:46:54 -0800 [thread overview]
Message-ID: <1328248014.2581.33.camel@jtkirshe-mobl> (raw)
In-Reply-To: <20120202.142005.1066192595268413170.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 767 bytes --]
On Thu, 2012-02-02 at 14:20 -0500, David Miller wrote:
> From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> Date: Thu, 2 Feb 2012 04:20:17 -0800
>
> > Several functions are made external but are not used externally when
> > FCoE/DCB is not enabled.
> >
> > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> > Tested-by: Phil Schmitt <phillip.j.schmitt@intel.com>
>
> Do not crap up the *.c files with ifdefs like this.
>
> Better to export these operations via an ops structure of
> some kind, rather than doing stuff like this.
>
> I'm not applying this series if it contains stuff like
> this.
I apologize Dave, that was my mistake. I will drop this patch from the
series and find a better way to resolve the namespace errors.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-02-03 5:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-02 12:20 [net 0/8][pull request] Intel Wired LAN Driver Update Jeff Kirsher
2012-02-02 12:20 ` [net 1/8] ixgbe: update copyright to 2012 Jeff Kirsher
2012-02-02 12:20 ` [net 2/8] ixgbe: Add warning when no space left for more MAC filters Jeff Kirsher
2012-02-02 12:20 ` [net 3/8] ixgbe: make ethtool strings table const Jeff Kirsher
2012-02-02 12:20 ` [net 4/8] ixgbe: fix namespace issues when FCoE is not enabled Jeff Kirsher
2012-02-02 19:20 ` David Miller
2012-02-03 5:46 ` Jeff Kirsher [this message]
2012-02-02 12:20 ` [net 5/8] ixgbevf: Fix mailbox interrupt ack bug Jeff Kirsher
2012-02-02 12:20 ` [net 6/8] ixgbevf: Update copyright notices Jeff Kirsher
2012-02-02 12:20 ` [net 7/8] igbvf: change copyright date Jeff Kirsher
2012-02-02 12:20 ` [net 8/8] ixgbe: Fix typo in ixgbe_common.h Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1328248014.2581.33.camel@jtkirshe-mobl \
--to=jeffrey.t.kirsher@intel.com \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox