netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shawn Lu <shawn.lu@ericsson.com>
To: eric.dumazet@gmail.com
Cc: davem@davemloft.net, netdev@vger.kernel.org, xiaoclu@gmail.com
Subject: [PATCH] tcp_v4_send_reset: binding oif to iif in no sock case
Date: Sat, 4 Feb 2012 13:22:36 -0800	[thread overview]
Message-ID: <1328390556-14906-1-git-send-email-shawn.lu@ericsson.com> (raw)
In-Reply-To: <RE: [PATCH] tcp: RST: binding oif to iif for tcp v4>

Binding RST packet outgoing interface to incomming interface
for tcp v4 when there is no socket associate with it.
This has few benefits:
1. tcp_v6_send_reset already did that.

2. This helps tcp connect with SO_BINDTODEVICE set. When connection
is lost, we still able to sending out RST using same interface.

3. we are send reply, it is most likely to be succeed if iif
is used

Signed-off-by: Shawn Lu <shawn.lu@ericsson.com>
---
V2: amend as Eric Dumazet suggested
 net/ipv4/tcp_ipv4.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c
index 90e4793..f2fde8d 100644
--- a/net/ipv4/tcp_ipv4.c
+++ b/net/ipv4/tcp_ipv4.c
@@ -676,6 +676,12 @@ static void tcp_v4_send_reset(struct sock *sk, struct sk_buff *skb)
 				      arg.iov[0].iov_len, IPPROTO_TCP, 0);
 	arg.csumoffset = offsetof(struct tcphdr, check) / 2;
 	arg.flags = (sk && inet_sk(sk)->transparent) ? IP_REPLY_ARG_NOSRCCHECK : 0;
+	/*
+	 * When socket is gone, all binding information is lost.
+	 * routing might fail in this case. using iif for oif to
+	 * make sure we can deliver it
+	 */
+	arg.bound_dev_if = sk ? sk->sk_bound_dev_if : inet_iif(skb);
 
 	net = dev_net(skb_dst(skb)->dev);
 	arg.tos = ip_hdr(skb)->tos;
-- 
1.7.0.4

       reply	other threads:[~2012-02-04 21:22 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <RE: [PATCH] tcp: RST: binding oif to iif for tcp v4>
2012-02-04 21:22 ` Shawn Lu [this message]
2012-02-04 21:26   ` [PATCH] tcp_v4_send_reset: binding oif to iif in no sock case David Miller
2012-02-04 21:30     ` Shawn Lu
2012-02-04 21:34     ` [PATCH] CodingStyle: Add net and drivers/net preferred commenting style Joe Perches
2012-02-04 21:40       ` David Miller
2012-02-04 21:50         ` Joe Perches
2012-02-04 21:53           ` David Miller
2012-02-04 22:02             ` Joe Perches
2012-02-05  1:52     ` [PATCH] tcp_v4_send_reset: binding oif to iif in no sock case Ben Greear
     [not found] <RE: [PATCH] tcp_v4_send_reset: binding oif to iif in no sock case>
2012-02-04 21:44 ` Shawn Lu
2012-02-04 21:47   ` David Miller
2012-02-04 22:47     ` Shawn Lu
2012-02-04 21:49   ` Eric Dumazet
2012-02-04 22:38 ` Shawn Lu
2012-02-04 23:20   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1328390556-14906-1-git-send-email-shawn.lu@ericsson.com \
    --to=shawn.lu@ericsson.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=xiaoclu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).