From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: David Miller <davem@davemloft.net>
Cc: gregory.v.rose@intel.com, netdev@vger.kernel.org,
gospo@redhat.com, sassmann@redhat.com, stable@vger.kernel.org
Subject: Re: [net 3/8] ixgbe: fix vf lookup
Date: Thu, 09 Feb 2012 01:06:15 -0800 [thread overview]
Message-ID: <1328778375.6576.3.camel@jtkirshe-mobl> (raw)
In-Reply-To: <20120208.183314.265645315647132912.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 800 bytes --]
On Wed, 2012-02-08 at 18:33 -0500, David Miller wrote:
> From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> Date: Wed, 8 Feb 2012 01:36:33 -0800
>
> > - if (pvfdev->devfn == vf_devfn)
> > + if (pvfdev->devfn == vf_devfn &&
> > + (pvfdev->bus->number >=
> pdev->bus->number))
>
> Come on.... do you look at these patches at all?
>
> I don't think you did, because this kind of code formatting stuff
> sticks out like a sore thumb.
Your right, I over-looked this, and it is especially bad since I caught
the problem with the igb patch (which was right before this one). I
remember thinking that I need to make sure the ixgbe patch did not have
the same formatting issue. But completely forgot before I applied the
patch.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-02-09 9:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-08 9:36 [net 0/8][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2012-02-08 9:36 ` [net 1/8] e1000: add dropped DMA receive enable back in for WoL Jeff Kirsher
2012-02-08 9:36 ` [net 2/8] igb: fix vf lookup Jeff Kirsher
2012-02-08 23:42 ` Rose, Gregory V
2012-02-08 23:49 ` Joe Perches
2012-02-08 23:52 ` David Miller
2012-02-08 23:55 ` Rose, Gregory V
2012-02-09 9:10 ` Jeff Kirsher
2012-02-08 9:36 ` [net 3/8] ixgbe: " Jeff Kirsher
2012-02-08 23:33 ` David Miller
2012-02-08 23:39 ` Rose, Gregory V
2012-02-09 9:06 ` Jeff Kirsher [this message]
2012-02-08 9:36 ` [net 4/8] ixgbe: Fix case of Tx Hang in PF with 32 VFs Jeff Kirsher
2012-02-08 9:36 ` [net 5/8] ixgbe: Fix broken dependency on MAX_SKB_FRAGS being related to page size Jeff Kirsher
2012-02-08 9:36 ` [net 6/8] ixgbe: do not update real num queues when netdev is going away Jeff Kirsher
2012-02-08 9:36 ` [net 7/8] ixgbe: dcb: up2tc mapping lost on disable/enable CEE DCB state Jeff Kirsher
2012-02-08 9:36 ` [net 8/8] ixgbe: ethtool: stats user buffer overrun Jeff Kirsher
2012-02-08 15:17 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1328778375.6576.3.camel@jtkirshe-mobl \
--to=jeffrey.t.kirsher@intel.com \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=gregory.v.rose@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).