netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>
To: Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
Cc: "Gustavo F. Padovan"
	<padovan-Y3ZbgMPKUGA34EUeqzHoZw@public.gmane.org>,
	"David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
	linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/2] bluetooth: Use more current logging styles
Date: Mon, 13 Feb 2012 08:30:33 +0100	[thread overview]
Message-ID: <1329118233.28848.62.camel@aeonflux> (raw)
In-Reply-To: <1329118080.31068.4.camel@joe2Laptop>

Hi Joe,

> > > There shouldn't be a newline at all with the
> > > actual functions bt_err or bt_info except
> > > at the uses.
> > then you might wanna read your patch again ;)
> 
> Yup, there's no newline with bt_info
> and there shouldn't be one with bt_err
> either.  There is though.  Oh well.
> Easy to fix at your end if you like.

and why exactly is this my job now to fix your broken patch?

Regards

Marcel

  reply	other threads:[~2012-02-13  7:30 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-13  3:15 [PATCH 0/2] bluetooth: logging cleanups and trivial object shrinking Joe Perches
2012-02-13  3:15 ` [PATCH 1/2] bluetooth: Use more current logging styles Joe Perches
2012-02-13  6:35   ` Marcel Holtmann
2012-02-13  6:46     ` Joe Perches
2012-02-13  7:21       ` Marcel Holtmann
2012-02-13  7:28         ` Joe Perches
2012-02-13  7:30           ` Marcel Holtmann [this message]
2012-02-13  8:24             ` Joe Perches
2012-02-13 21:56     ` Gustavo Padovan
2012-02-14  2:02       ` Joe Perches
2012-02-16 16:43         ` Joe Perches
2012-02-16 18:05           ` Gustavo Padovan
2012-02-16 21:33             ` David Miller
2012-02-17  8:58               ` Marcel Holtmann
2012-02-13  3:15 ` [PATCH 2/2] bluetooth: Convert BT_DBG to pr_debug Joe Perches
2012-02-13  6:37   ` Marcel Holtmann
2012-02-13  6:51     ` Joe Perches
2012-02-13  7:19       ` Marcel Holtmann
2012-02-13  7:24         ` Joe Perches
2012-02-13  9:21       ` Andrei Emeltchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1329118233.28848.62.camel@aeonflux \
    --to=marcel-kz+m5ild9qbg9huczpvpmw@public.gmane.org \
    --cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
    --cc=joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org \
    --cc=linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=padovan-Y3ZbgMPKUGA34EUeqzHoZw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).