From mboxrd@z Thu Jan 1 00:00:00 1970 From: Axel Lin Subject: [PATCH] RxRPC: Fix kcalloc parameters swapped Date: Tue, 14 Feb 2012 14:19:14 +0800 Message-ID: <1329200354.3806.1.camel@phoenix> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: "David S. Miller" , David Howells , Mimi Zohar , Thomas Meyer , Anton Blanchard , netdev@vger.kernel.org To: linux-kernel@vger.kernel.org Return-path: Received: from mail-pw0-f46.google.com ([209.85.160.46]:61414 "EHLO mail-pw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751396Ab2BNGTW (ORCPT ); Tue, 14 Feb 2012 01:19:22 -0500 Sender: netdev-owner@vger.kernel.org List-ID: The first parameter should be "number of elements" and the second parameter should be "element size". Signed-off-by: Axel Lin --- net/rxrpc/ar-key.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/net/rxrpc/ar-key.c b/net/rxrpc/ar-key.c index 4cba13e..ae3a035 100644 --- a/net/rxrpc/ar-key.c +++ b/net/rxrpc/ar-key.c @@ -232,7 +232,7 @@ static int rxrpc_krb5_decode_principal(struct krb5_principal *princ, if (toklen <= (n_parts + 1) * 4) return -EINVAL; - princ->name_parts = kcalloc(sizeof(char *), n_parts, GFP_KERNEL); + princ->name_parts = kcalloc(n_parts, sizeof(char *), GFP_KERNEL); if (!princ->name_parts) return -ENOMEM; @@ -355,7 +355,7 @@ static int rxrpc_krb5_decode_tagged_array(struct krb5_tagged_data **_td, _debug("n_elem %d", n_elem); - td = kcalloc(sizeof(struct krb5_tagged_data), n_elem, + td = kcalloc(n_elem, sizeof(struct krb5_tagged_data), GFP_KERNEL); if (!td) return -ENOMEM; -- 1.7.5.4