From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] netem: fix unwanted reordering
Date: Thu, 16 Feb 2012 07:13:06 +0100 [thread overview]
Message-ID: <1329372786.5646.7.camel@edumazet-laptop> (raw)
In-Reply-To: <1329371375.5646.6.camel@edumazet-laptop>
Le jeudi 16 février 2012 à 06:49 +0100, Eric Dumazet a écrit :
> commit 50612537e9 (netem: fix classful handling) added in typo in
> netem_dequeue() :
>
> After checking skb at the head of tfifo queue for time constraints, it
> dequeues tail skb, thus adding unwanted reordering.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
> ---
> net/sched/sch_netem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Please dont apply this patch, there is a 2nd issue I must fix as well
(qdisc stats are updated twice)
prev parent reply other threads:[~2012-02-16 6:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-16 5:49 [PATCH] netem: fix unwanted reordering Eric Dumazet
2012-02-16 6:13 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1329372786.5646.7.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox