From: Ben Hutchings <bhutchings@solarflare.com>
To: David Miller <davem@davemloft.net>
Cc: <Ajit.Khaparde@Emulex.Com>, <shemminger@linux-foundation.org>,
<netdev@vger.kernel.org>
Subject: Re: [RFC net-next 1/2] if_link : add support for VF privileges
Date: Tue, 21 Feb 2012 22:43:22 +0000 [thread overview]
Message-ID: <1329864202.2689.56.camel@bwh-desktop> (raw)
In-Reply-To: <20120221.170441.1552294498786802979.davem@davemloft.net>
On Tue, 2012-02-21 at 17:04 -0500, David Miller wrote:
> From: <Ajit.Khaparde@Emulex.Com>
> Date: Tue, 21 Feb 2012 14:02:27 -0800
>
> >> -----Original Message-----
> >> From: Ben Hutchings [mailto:bhutchings@solarflare.com]
> >> Sent: Tuesday, February 14, 2012 5:25 PM
> >> To: Khaparde, Ajit
> >> Cc: davem@davemloft.net; shemminger@linux-foundation.org;
> >> netdev@vger.kernel.org
> >> Subject: Re: [RFC net-next 1/2] if_link : add support for VF privileges
> >>
> >> On Tue, 2012-02-14 at 13:26 -0600, Ajit Khaparde wrote:
> >> > +enum {
> >> > + IFLA_VF_PRIVILEGE_DEFAULT = 1, /* Default privileges */
> >>
> >> What are the default privileges? Should existing drivers report that
> >> their VFs have this?
> > Yes. Vendors can decide what privileges they want to grant for VFs by default.
>
> That's terrible and a very bad interface for users. It means every system
> can have different defaults, from which we'll derive zero consistency.
Aside from this, my concern is that if we assign privilege flags to
capabilities that VFs normally have now then the value reported where
the driver doesn't support this new operation should not be 0.
(Also, if a privilege is assigned by default, is it really a privilege?
Wouldn't 'capability' or 'permission' be a better term?)
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2012-02-21 22:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-14 19:26 [RFC net-next 1/2] if_link : add support for VF privileges Ajit Khaparde
2012-02-14 23:24 ` Ben Hutchings
2012-02-21 22:02 ` Ajit.Khaparde
2012-02-21 22:04 ` David Miller
2012-02-21 22:43 ` Ben Hutchings [this message]
2012-03-01 18:54 ` Ajit.Khaparde
2012-03-01 18:53 ` Ajit.Khaparde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1329864202.2689.56.camel@bwh-desktop \
--to=bhutchings@solarflare.com \
--cc=Ajit.Khaparde@Emulex.Com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).