From: Joe Perches <joe@perches.com>
To: "N, Mugunthan V" <mugunthanvnm@ti.com>,
Andy Whitcroft <apw@shadowen.org>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: RE: [PATCH v2 2/2] netdev: driver: ethernet: Add TI CPSW driver
Date: Thu, 23 Feb 2012 07:46:02 -0800 [thread overview]
Message-ID: <1330011962.5143.50.camel@joe2Laptop> (raw)
In-Reply-To: <EB1619762EAF8B4E97A227FB77B7E0293178F468@DBDE01.ent.ti.com>
On Thu, 2012-02-23 at 12:47 +0000, N, Mugunthan V wrote:
> Joe/David
> > > -----Original Message-----
> > > From: Joe Perches [mailto:joe@perches.com]
> > > Sent: Tuesday, February 21, 2012 4:34 AM
> [...]
> > > Add
> > > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> > > before all #includes and remove the embedded prefix
> > > from all pr_<level> uses.
> > Agreed, will make use of pr_fmt and remove embedded prefix in pr_<level>
> > uses
> Adding
> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> in the driver gives a checkpatch error as follows
> #77: FILE: drivers/net/ethernet/ti/cpsw.c:16:
> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> total: 1 errors, 0 warnings, 1137 lines checked
> Is it ok to ignore the checkpatch error as most of the drivers use it.
Yes.
Andy Whitcroft has a pending checkpatch fix
for this. I hope he pushes it out soon.
next prev parent reply other threads:[~2012-02-23 15:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-20 18:37 [PATCH v2 0/2] Adding new TI Common Platform ethernet SWitch driver Mugunthan V N
2012-02-20 18:37 ` [PATCH v2 1/2] netdev: driver: ethernet: add cpsw address lookup engine support Mugunthan V N
2012-02-20 22:37 ` Joe Perches
2012-02-22 16:43 ` N, Mugunthan V
2012-02-20 18:37 ` [PATCH v2 2/2] netdev: driver: ethernet: Add TI CPSW driver Mugunthan V N
2012-02-20 23:03 ` Joe Perches
2012-02-22 16:43 ` N, Mugunthan V
2012-02-23 12:47 ` N, Mugunthan V
2012-02-23 15:46 ` Joe Perches [this message]
2012-02-23 16:38 ` Andy Whitcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330011962.5143.50.camel@joe2Laptop \
--to=joe@perches.com \
--cc=apw@shadowen.org \
--cc=davem@davemloft.net \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox