From: Florian Fainelli <f.fainelli@gmail.com>
To: Alexander Loktionov <Alexander.Loktionov@aquantia.com>,
netdev@vger.kernel.org, David VomLehn <vomlehn@texas.net>
Cc: "David S . Miller" <davem@davemloft.net>,
Simon Edelhaus <Simon.Edelhaus@aquantia.com>,
Dmitrii Tarakanov <Dmitrii.Tarakanov@aquantia.com>,
Pavel Belous <Pavel.Belous@aquantia.com>,
Dmitry Bezrukov <Dmitry.Bezrukov@aquantia.com>
Subject: Re: [PATCH v7 00/13] net: ethernet: aquantia: Add AQtion 2.5/5 GB NIC driver
Date: Thu, 19 Jan 2017 14:41:26 -0800 [thread overview]
Message-ID: <13303162-471c-de9c-a222-6bdbf5f38db9@gmail.com> (raw)
In-Reply-To: <cover.1484860589.git.vomlehn@texas.net>
On 01/19/2017 01:33 PM, Alexander Loktionov wrote:
> From: David VomLehn <vomlehn@texas.net>
>
> This series introduces the AQtion NIC driver for the aQuantia
> AQC107/AQC108 network devices.
> v5: o Removed extra newline at the end of the files.
> v6: o Removed unnecessary cast from void*.
> o Reworked strings array for ethtool statistics.
> o Added stringset == ETH_SS_STATS checking.
> o AQ_OBJ_HEADER replaced to aq_obj_header_s struct.
> o AQ_OBJ_SET/TST/CLR macroses replaced to inline functions.
> o Driver sources placed in to atlantic directory.
> o Fixed compilation warnings (Make W=1)
> o Added firmware version checking.
> o Code cleaning.
> v7 o Removed unnecessary cast from memory allocation function (aq_ring.c).
In general, you may want for a couple of days before resubmitting new
versions that only fix minor stuff like what happened here between v6
and v7.
Some general comments on the coding style, it is usually preferred not
to name a structure e.g; struct foo_s, but just struct foo, you are also
saving bytes (and therefore trees!).
--
Florian
next prev parent reply other threads:[~2017-01-19 22:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 21:33 [PATCH v7 00/13] net: ethernet: aquantia: Add AQtion 2.5/5 GB NIC driver Alexander Loktionov
2017-01-19 21:33 ` [PATCH v7 01/13] net: ethernet: aquantia: Make and configuration files Alexander Loktionov
2017-01-19 21:33 ` [PATCH v7 02/13] net: ethernet: aquantia: Common functions and definitions Alexander Loktionov
2017-01-19 21:33 ` [PATCH v7 03/13] net: ethernet: aquantia: Add ring support code Alexander Loktionov
2017-01-19 21:33 ` [PATCH v7 04/13] net: ethernet: aquantia: Low-level hardware interfaces Alexander Loktionov
2017-01-19 21:33 ` [PATCH v7 05/13] net: ethernet: aquantia: Support for NIC-specific code Alexander Loktionov
2017-01-19 21:33 ` [PATCH v7 06/13] net: ethernet: aquantia: Atlantic A0 and B0 specific functions Alexander Loktionov
2017-01-19 21:33 ` [PATCH v7 07/13] net: ethernet: aquantia: Vector operations Alexander Loktionov
2017-01-19 21:33 ` [PATCH v7 08/13] net: ethernet: aquantia: PCI operations Alexander Loktionov
2017-01-19 21:33 ` [PATCH v7 09/13] net: ethernet: aquantia: Atlantic hardware abstraction layer Alexander Loktionov
2017-01-19 21:33 ` [PATCH v7 10/13] net: ethernet: aquantia: Hardware interface and utility functions Alexander Loktionov
2017-01-19 22:40 ` Florian Fainelli
2017-01-19 21:33 ` [PATCH v7 11/13] net: ethernet: aquantia: Ethtool support Alexander Loktionov
2017-01-19 22:34 ` Florian Fainelli
2017-01-20 14:33 ` Rami Rosen
2017-01-19 21:33 ` [PATCH v7 12/13] net: ethernet: aquantia: Receive side scaling Alexander Loktionov
2017-01-19 21:33 ` [PATCH v7 13/13] net: ethernet: aquantia: Integrate AQtion 2.5/5 GB NIC driver Alexander Loktionov
2017-01-19 22:41 ` Florian Fainelli [this message]
2017-01-19 22:45 ` [PATCH v7 00/13] net: ethernet: aquantia: Add " David VomLehn
2017-01-19 22:50 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13303162-471c-de9c-a222-6bdbf5f38db9@gmail.com \
--to=f.fainelli@gmail.com \
--cc=Alexander.Loktionov@aquantia.com \
--cc=Dmitrii.Tarakanov@aquantia.com \
--cc=Dmitry.Bezrukov@aquantia.com \
--cc=Pavel.Belous@aquantia.com \
--cc=Simon.Edelhaus@aquantia.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=vomlehn@texas.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).