From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: paul.gortmaker@windriver.com, tim.bird@am.sony.com,
kuznet@ms2.inr.ac.ru, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: RFC: memory leak in udp_table_init
Date: Mon, 27 Feb 2012 06:40:23 +0100 [thread overview]
Message-ID: <1330321223.3330.1.camel@edumazet-laptop> (raw)
In-Reply-To: <20120226.142038.556939530554716833.davem@davemloft.net>
Le dimanche 26 février 2012 à 14:20 -0500, David Miller a écrit :
> From: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Sat, 25 Feb 2012 06:19:42 +0100
>
> > [PATCH] mm: add a low limit to alloc_large_system_hash
>
> I think you should just use zero as the default minimum for all
> call sites except this UDP case we are trying to fix.
>
> For example I see you used 16 for kernel/pid.c
>
> Let's not try to do unrelated changes like that now, we can do such
> tweaks later.
It was to match the comment we have few lines above :
/*
* The pid hash table is scaled according to the amount of memory in the
* machine. From a minimum of 16 slots up to 4096 slots at one gigabyte or
* more.
*/
next prev parent reply other threads:[~2012-02-27 5:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-25 0:55 RFC: memory leak in udp_table_init Tim Bird
2012-02-25 1:27 ` Paul Gortmaker
2012-02-25 5:19 ` Eric Dumazet
2012-02-26 19:20 ` David Miller
2012-02-27 5:40 ` Eric Dumazet [this message]
2012-02-27 5:44 ` David Miller
2012-02-27 11:33 ` David Laight
2012-02-29 18:28 ` Eric W. Biederman
2012-03-01 8:55 ` David Laight
2012-03-01 12:33 ` Eric Dumazet
2012-03-15 17:44 ` Paul E. McKenney
2012-03-02 0:12 ` Eric W. Biederman
2012-02-27 6:03 ` [PATCH v2] mm: add a low limit to alloc_large_system_hash Eric Dumazet
2012-02-27 6:45 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330321223.3330.1.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=tim.bird@am.sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox