From: Joe Perches <joe@perches.com>
To: Roland Stigge <stigge@antcom.de>
Cc: davem@davemloft.net, jeffrey.t.kirsher@intel.com,
alexander.h.duyck@intel.com, eilong@broadcom.com,
ian.campbell@citrix.com, netdev@vger.kernel.org,
w.sang@pengutronix.de, linux-kernel@vger.kernel.org,
kevin.wells@nxp.com, linux-arm-kernel@lists.infradead.org,
arnd@arndb.de, baruch@tkos.co.il
Subject: Re: [PATCH v3] lpc32xx: Added ethernet driver
Date: Mon, 27 Feb 2012 09:57:29 -0800 [thread overview]
Message-ID: <1330365449.9942.26.camel@joe2Laptop> (raw)
In-Reply-To: <1330364539-23152-1-git-send-email-stigge@antcom.de>
On Mon, 2012-02-27 at 18:42 +0100, Roland Stigge wrote:
> This patch adds an ethernet driver for the LPC32xx ARM SoC.
This looks nicer to me, thanks.
Just a few more trivial comments.
[]
> +++ linux-2.6/drivers/net/ethernet/nxp/lpc_eth.c
[]
> +static int lpc_mdio_read(struct mii_bus *bus, int phy_id, int phyreg)
> +{
> + struct netdata_local *pldat = bus->priv;
> + unsigned long timeout = jiffies + ((HZ * 100) / 1000); /* 100mS */
msecs_to_jiffies?
> +static void __lpc_handle_xmit(struct net_device *ndev)
> +{
[]
> + /* Any errors occurred? */
> + if (txstat & 0x80000000) {
> + if (txstat & 0x20000000) {
It might be clearer to use #defines
> + /* FIFO underrun */
> + ndev->stats.tx_fifo_errors++;
> + ndev->stats.tx_errors++;
> + }
> + if (txstat & 0x10000000) {
> + /* Late collision */
> + ndev->stats.tx_aborted_errors++;
> + ndev->stats.tx_errors++;
double counting tx_errors?
next prev parent reply other threads:[~2012-02-27 17:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-27 17:42 [PATCH v3] lpc32xx: Added ethernet driver Roland Stigge
2012-02-27 17:57 ` Joe Perches [this message]
2012-02-27 19:42 ` Kevin Wells
2012-02-27 19:49 ` Arnd Bergmann
2012-03-01 20:42 ` Roland Stigge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330365449.9942.26.camel@joe2Laptop \
--to=joe@perches.com \
--cc=alexander.h.duyck@intel.com \
--cc=arnd@arndb.de \
--cc=baruch@tkos.co.il \
--cc=davem@davemloft.net \
--cc=eilong@broadcom.com \
--cc=ian.campbell@citrix.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=kevin.wells@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stigge@antcom.de \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).