From: Tim Hartrick <tim@edgecast.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>
Cc: Netdev <netdev@vger.kernel.org>
Subject: Re: crash in tcp_fragment
Date: Mon, 27 Feb 2012 16:29:52 -0700 [thread overview]
Message-ID: <1330385392.7041.16.camel@boudreau> (raw)
In-Reply-To: <alpine.DEB.2.00.1202280115020.17924@melkinpaasi.cs.helsinki.fi>
Ilpo,
Thanks for the answers. This gives me some clarity on how to address
the problem.
Tim Hartrick
On Tue, 2012-02-28 at 01:18 +0200, Ilpo Järvinen wrote:
> On Sun, 26 Feb 2012, Tim Hartrick wrote:
>
> > We have been seeing the crash cited below on a number of our systems
> > running kernel version 2.6.34, 2.6.36 and 2.6.38 using a number of
> > different GigE controllers. I note that commit
> > 2fceec13375e5d98ef033c6b0ee03943fc460950 introduced a band-aid for the
> > problem by replacing the BUG_ON() to a WARN(). I have two questions
> > related to this.
> >
> > 1) Is there a fix for the root cause? Can I get a pointer to the commit
> > that claims to address the root cause?
>
> There have been multiple fixes recently on the counters which this code
> depends on, however, nobody has afaict fully analyzed what else those
> fixed.
>
> > 2) Will disabling GSO/TSO make the problem go away? That is, is
> > something related to GSO/TSO at the root of the problem?
>
> Very likely.
>
next prev parent reply other threads:[~2012-02-27 23:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-27 2:57 crash in tcp_fragment Tim Hartrick
2012-02-27 23:18 ` Ilpo Järvinen
2012-02-27 23:29 ` Tim Hartrick [this message]
2012-03-03 7:38 ` Neal Cardwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330385392.7041.16.camel@boudreau \
--to=tim@edgecast.com \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).