From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Hutchings Subject: Re: [PATCH v2] ARM: LPC32xx: Ethernet driver Date: Tue, 28 Feb 2012 15:53:30 +0000 Message-ID: <1330444410.8460.160.camel@deadeye> References: <4F4CD781.2090802@antcom.de> <201202281341.01690.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Roland Stigge , David Laight , , , , , , Kevin Wells , Wolfram Sang , , , To: Arnd Bergmann Return-path: In-Reply-To: <201202281341.01690.arnd@arndb.de> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Tue, 2012-02-28 at 13:41 +0000, Arnd Bergmann wrote: > On Tuesday 28 February 2012, Roland Stigge wrote: > > Yes, that's why we previously had a cmdline param for it (but removed it > > upon request from the netdev maintainer). > > > > So if the hardware defaults to 00:00:00:00:00:00, what is the > > "consistent policy we want to enforce in all drivers"? > > > > A link or hint would be sufficient. > > I think the most common strategy for platform drivers these days is > > 1. use what the hardware provides > 2. call of_get_mac_address(dev->of_node, ...) > 3. use random_ether_addr The 3rd option should now be eth_hw_addr_random(). Ben. > in that order. of_get_mac_address just returns NULL when there > is no device tree or no local-mac-address property, so you can > put it into the driver right away. > > Arnd > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.