From: Joe Perches <joe@perches.com>
To: Mugunthan V N <mugunthanvnm@ti.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH v4 2/2] netdev: driver: ethernet: Add TI CPSW driver
Date: Tue, 28 Feb 2012 21:04:07 -0800 [thread overview]
Message-ID: <1330491847.4352.6.camel@joe2Laptop> (raw)
In-Reply-To: <1330490737-28973-3-git-send-email-mugunthanvnm@ti.com>
On Wed, 2012-02-29 at 10:15 +0530, Mugunthan V N wrote:
> This patch adds support for TI's CPSW driver.
[]
> +static int cpsw_poll(struct napi_struct *napi, int budget)
> +{
> + struct cpsw_priv *priv = napi_to_priv(napi);
> + int num_tx, num_rx;
> +
> + num_tx = cpdma_chan_process(priv->txch, 128);
> + num_rx = cpdma_chan_process(priv->rxch, budget);
> +
> + if (num_rx || num_tx)
> + cpsw_dbg(priv, intr, pr_fmt("poll %d rx, %d tx pkts"),
> + num_rx, num_tx);
You don't need pr_fmt() for any of these cpsw_<level> uses.
but you do need a terminating "\n".
> +static int __devinit cpsw_probe(struct platform_device *pdev)
[]
> + if (!data) {
> + pr_err("cpsw: platform data missing\n");
Don't need "cpsw: " prefix
next prev parent reply other threads:[~2012-02-29 5:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-29 4:45 [PATCH v4 0/2] Adding new TI Common Platform ethernet SWitch driver Mugunthan V N
2012-02-29 4:45 ` [PATCH v4 1/2] netdev: driver: ethernet: add cpsw address lookup engine support Mugunthan V N
2012-02-29 4:48 ` Joe Perches
2012-02-29 15:27 ` N, Mugunthan V
2012-02-29 4:45 ` [PATCH v4 2/2] netdev: driver: ethernet: Add TI CPSW driver Mugunthan V N
2012-02-29 5:04 ` Joe Perches [this message]
2012-02-29 13:15 ` Peter Korsgaard
2012-02-29 16:28 ` N, Mugunthan V
2012-03-01 13:40 ` Peter Korsgaard
2012-03-16 10:21 ` N, Mugunthan V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330491847.4352.6.camel@joe2Laptop \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).