From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Hutchings Subject: Re: [PATCH net-next] mdio: Export mdio.h to userland Date: Wed, 29 Feb 2012 19:12:34 +0000 Message-ID: <1330542754.5881.4.camel@bwh-desktop> References: <1330542122.5881.2.camel@bwh-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: , To: David Miller Return-path: Received: from mail.solarflare.com ([216.237.3.220]:62210 "EHLO ocex02.SolarFlarecom.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1030878Ab2B2TMh (ORCPT ); Wed, 29 Feb 2012 14:12:37 -0500 In-Reply-To: <1330542122.5881.2.camel@bwh-desktop> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 2012-02-29 at 19:02 +0000, Ben Hutchings wrote: > The ID packing/unpacking functions are needed by userland and the > register definitions may also be useful there. Minor issue with this: mdio_phy_id_is_c45() returns bool, and that's not defined by default. Should I add #include or change the return type to int for maximum compatibility? Ben. > Signed-off-by: Ben Hutchings > --- > include/linux/Kbuild | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/include/linux/Kbuild b/include/linux/Kbuild > index c94e717..4b0b7ed 100644 > --- a/include/linux/Kbuild > +++ b/include/linux/Kbuild > @@ -238,6 +238,7 @@ header-y += magic.h > header-y += major.h > header-y += map_to_7segment.h > header-y += matroxfb.h > +header-y += mdio.h > header-y += media.h > header-y += mempolicy.h > header-y += meye.h > -- > 1.7.7.6 > > -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.