From: Joe Perches <joe@perches.com>
To: Bing Zhao <bzhao@marvell.com>,
Kalle Valo <kvalo@qca.qualcomm.com>,
Andy Whitcroft <apw@shadowen.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: "John W. Linville" <linville@tuxdriver.com>,
Ilan Elias <ilane@ti.com>, Samuel Ortiz <sameo@linux.intel.com>,
Amitkumar Karwar <akarwar@marvell.com>,
LKML <linux-kernel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>
Subject: RE: coding style issues -- [davem@davemloft.net: Re: pull request: wireless-next 2012-02-06]
Date: Wed, 29 Feb 2012 11:13:31 -0800 [thread overview]
Message-ID: <1330542811.21491.7.camel@joe2Laptop> (raw)
In-Reply-To: <477F20668A386D41ADCC57781B1F70430836762D55@SC-VEXCH1.marvell.com>
On Wed, 2012-02-29 at 10:57 -0800, Bing Zhao wrote:
> Joe Perches submitted a patch "[PATCH v2] checkpatch: Add some --strict coding style checks"
> I have applied Joe's patch to my local git tree.
>
> All new patches will follow Dave's rules and be checked with --strict option.
> Furthermore, we will have a series of cleanup patches to address the coding style issues in existing code.
Hi Bing.
There's an issue with the checkpatch patch.
It doesn't always work correctly when there
are consecutive parenthesis.
Kalle Valo showed an example that fails:
if (!IS_ALIGNED((unsigned long) skb->data - HTC_HDR_LENGTH, 4) &&
skb_cloned(skb)) {
I have a tentative fix here, but I'm waiting on
Andy Whitcroft to give some guidance on how best
to fix it given a minimum perl version of 5.10.
The proposed patch doesn't work with perl versions
less than 5.10 and there is at least one person
that still uses 5.8.
next parent reply other threads:[~2012-02-29 19:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120229173421.GA13733@tuxdriver.com>
[not found] ` <477F20668A386D41ADCC57781B1F70430836762D55@SC-VEXCH1.marvell.com>
2012-02-29 19:13 ` Joe Perches [this message]
2012-02-29 19:22 ` coding style issues -- [davem@davemloft.net: Re: pull request: wireless-next 2012-02-06] Bing Zhao
2012-03-01 4:24 ` [PATCH v3] checkpatch: Add some --strict coding style checks Joe Perches
2012-03-01 5:10 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330542811.21491.7.camel@joe2Laptop \
--to=joe@perches.com \
--cc=akarwar@marvell.com \
--cc=akpm@linux-foundation.org \
--cc=apw@shadowen.org \
--cc=bzhao@marvell.com \
--cc=ilane@ti.com \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).