From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Hutchings Subject: Re: [PATCH net-next] mdio: Export mdio.h to userland Date: Wed, 29 Feb 2012 23:09:52 +0000 Message-ID: <1330556992.5881.11.camel@bwh-desktop> References: <1330542754.5881.4.camel@bwh-desktop> <20120229.154227.908693909825012701.davem@davemloft.net> <1330555428.5881.8.camel@bwh-desktop> <20120229.180242.197576747542301377.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: , To: David Miller Return-path: Received: from mail.solarflare.com ([216.237.3.220]:12880 "EHLO ocex02.SolarFlarecom.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S964869Ab2B2XJ4 (ORCPT ); Wed, 29 Feb 2012 18:09:56 -0500 In-Reply-To: <20120229.180242.197576747542301377.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 2012-02-29 at 18:02 -0500, David Miller wrote: > From: Ben Hutchings > Date: Wed, 29 Feb 2012 22:43:48 +0000 > > > On Wed, 2012-02-29 at 15:42 -0500, David Miller wrote: > >> From: Ben Hutchings > >> Date: Wed, 29 Feb 2012 19:12:34 +0000 > >> > >> > On Wed, 2012-02-29 at 19:02 +0000, Ben Hutchings wrote: > >> >> The ID packing/unpacking functions are needed by userland and the > >> >> register definitions may also be useful there. > >> > > >> > Minor issue with this: mdio_phy_id_is_c45() returns bool, and that's not > >> > defined by default. Should I add #include or change the > >> > return type to int for maximum compatibility? > >> > >> I do not see any precedence for including stdbool.h in a kernel header > >> file. And I sure as hell am not going to compromise using a correct > >> type just to make this usable by userspace. > >> > >> I think this is of dubious value, and combined with the bool > >> complication I'm not going to apply this, sorry. > > > > Without this, userland doing clause 45 MDIO has to duplicate the ID > > packing definitions. > > Then come up with a real solution to the bool issue. > > But note that changing the bool to an int is not a solution, neither > is #include unless we can reach consensus on lkml that > this is OK. I could just move the mdio_phy_id_is_c45(), mdio_phy_id_prtad(), mdio_phy_id_devad() functions inside #ifdef __KERNEL__ since userland shouldn't need to unpack PHY IDs. Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.