From: Joe Perches <joe@perches.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Kalle Valo <kvalo@qca.qualcomm.com>,
Andy Whitcroft <apw@shadowen.org>,
David Miller <davem@davemloft.net>,
"John W. Linville" <linville@tuxdriver.com>,
Ilan Elias <ilane@ti.com>, Samuel Ortiz <sameo@linux.intel.com>,
Amitkumar Karwar <akarwar@marvell.com>,
LKML <linux-kernel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>,
"Bruce W. Allen" <bruce.w.allan@intel.com>,
Bing Zhao <bzhao@marvell.com>
Subject: Re: [PATCH v3] checkpatch: Add some --strict coding style checks
Date: Wed, 29 Feb 2012 21:10:22 -0800 [thread overview]
Message-ID: <1330578622.23314.53.camel@joe2Laptop> (raw)
In-Reply-To: <1330575843.23314.52.camel@joe2Laptop>
On Wed, 2012-02-29 at 20:24 -0800, Joe Perches wrote:
> Argument alignment across multiple lines should
> match the open parenthesis.
>
> Logical continuations should be at the end of
> the previous line, not the start of a new line.
>
> These are not required by CodingStyle so make the
> tests active only when using --strict.
>
> Improved_by_examples_from: "Bruce W. Allen" <bruce.w.allan@intel.com>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> V3: Use perl 5.10 features
> Use a runtime check of perl version so $balanced_parens
> is not used in perl versions that don't support it.
> Update memset and min_t checks for newer $balanced_parens
> test.
> Improve alignment position test.
> Add message suggesting perl upgrade.
Forgot to mention this stops a hang
in the memset tests.
prev parent reply other threads:[~2012-03-01 5:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120229173421.GA13733@tuxdriver.com>
[not found] ` <477F20668A386D41ADCC57781B1F70430836762D55@SC-VEXCH1.marvell.com>
2012-02-29 19:13 ` coding style issues -- [davem@davemloft.net: Re: pull request: wireless-next 2012-02-06] Joe Perches
2012-02-29 19:22 ` Bing Zhao
2012-03-01 4:24 ` [PATCH v3] checkpatch: Add some --strict coding style checks Joe Perches
2012-03-01 5:10 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330578622.23314.53.camel@joe2Laptop \
--to=joe@perches.com \
--cc=akarwar@marvell.com \
--cc=akpm@linux-foundation.org \
--cc=apw@shadowen.org \
--cc=bruce.w.allan@intel.com \
--cc=bzhao@marvell.com \
--cc=davem@davemloft.net \
--cc=ilane@ti.com \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).