netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] be2net: Remove unused OFFSET_IN_PAGE() macro
@ 2012-03-01  6:40 Roland Dreier
  2012-03-01 22:22 ` David Miller
  0 siblings, 1 reply; 3+ messages in thread
From: Roland Dreier @ 2012-03-01  6:40 UTC (permalink / raw)
  To: Sathya Perla, Subbu Seetharaman, Ajit Khaparde, netdev

From: Roland Dreier <roland@purestorage.com>

Signed-off-by: Roland Dreier <roland@purestorage.com>
---
 drivers/net/ethernet/emulex/benet/be.h |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/emulex/benet/be.h b/drivers/net/ethernet/emulex/benet/be.h
index cbdec25..cca5c0e 100644
--- a/drivers/net/ethernet/emulex/benet/be.h
+++ b/drivers/net/ethernet/emulex/benet/be.h
@@ -428,10 +428,6 @@ extern const struct ethtool_ops be_ethtool_ops;
 		((u32)((((size_t)(_address) & (PAGE_SIZE_4K - 1)) + 	\
 			(size) + (PAGE_SIZE_4K - 1)) >> PAGE_SHIFT_4K))
 
-/* Byte offset into the page corresponding to given address */
-#define OFFSET_IN_PAGE(addr)						\
-		 ((size_t)(addr) & (PAGE_SIZE_4K-1))
-
 /* Returns bit offset within a DWORD of a bitfield */
 #define AMAP_BIT_OFFSET(_struct, field)  				\
 		(((size_t)&(((_struct *)0)->field))%32)
-- 
1.7.9

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] be2net: Remove unused OFFSET_IN_PAGE() macro
  2012-03-01  6:40 [PATCH] be2net: Remove unused OFFSET_IN_PAGE() macro Roland Dreier
@ 2012-03-01 22:22 ` David Miller
  2012-03-05 20:39   ` Roland Dreier
  0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2012-03-01 22:22 UTC (permalink / raw)
  To: roland; +Cc: sathya.perla, subbu.seetharaman, ajit.khaparde, netdev

From: Roland Dreier <roland@kernel.org>
Date: Wed, 29 Feb 2012 22:40:46 -0800

> From: Roland Dreier <roland@purestorage.com>
> 
> Signed-off-by: Roland Dreier <roland@purestorage.com>

Applied.

I assume you are aware of the same issue in the be2iscsi driver.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] be2net: Remove unused OFFSET_IN_PAGE() macro
  2012-03-01 22:22 ` David Miller
@ 2012-03-05 20:39   ` Roland Dreier
  0 siblings, 0 replies; 3+ messages in thread
From: Roland Dreier @ 2012-03-05 20:39 UTC (permalink / raw)
  To: David Miller; +Cc: sathya.perla, subbu.seetharaman, ajit.khaparde, netdev

On Thu, Mar 1, 2012 at 2:22 PM, David Miller <davem@davemloft.net> wrote:
> I assume you are aware of the same issue in the be2iscsi driver.

Yeah, patch already sent:
http://www.spinics.net/lists/linux-scsi/msg57754.html

but the SCSI maintainer is not as responsive as the networking one ;)

 - R.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-03-05 20:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-01  6:40 [PATCH] be2net: Remove unused OFFSET_IN_PAGE() macro Roland Dreier
2012-03-01 22:22 ` David Miller
2012-03-05 20:39   ` Roland Dreier

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).