Re: pull request: bluetooth-next 2012-03-01

[Joe Perches <joe@perches.com>]

On Thu, 2012-03-01 at 22:26 -0500, David Miller wrote:
> You know what really pisses me off?  This is the one issue I made a huge
> stink about last week, arguments to function calls and prototypes lining
> up properl.  And it's in ever 2nd or 3rd commit in this pull request.
[]
> Come back when you've audited this whole thing properly and honestly.

I submitted a patch to checkpatch for a --strict rule for
this argument alignment.  https://lkml.org/lkml/2012/2/29/644

Are there any other tests you think should be added with
--strict?

Some I think possible are:

o no space after cast
	struct foo *bar = (struct foo *) baz;
sb:
	struct foo *bar = (struct foo *)baz;

o don't start comments with /*$
  (perhaps only if a blank line proceeds the comment)
	/*
	 * multiline comment
	 * ...
	 */
sb:
	/* multiline comment
	 * ...
	 */

o coalesce formats
	pr_<level>("format part 1 "
		   "format part 2\n", ...)
sb:
	pr_<level>("format part 1 format part 2\n",
		   ...);

o symmetric brace standardization
	if (foo) {
		bar;
		baz;
	} else
		bar;
sb:
	if (foo) {
		bar;
		baz;
	} else {
		bar;
	}

Any others?