* [PATCH 2/3] qla3xxx: ethernet: Silence static checker warning.
@ 2012-03-02 15:09 santosh nayak
2012-03-05 21:53 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: santosh nayak @ 2012-03-02 15:09 UTC (permalink / raw)
To: jitendra.kalsaria
Cc: ron.mercer, linux-driver, netdev, linux-kernel, kernel-janitors,
Santosh Nayak
From: Santosh Nayak <santoshprasadnayak@gmail.com>
Silence the following warning:
"warn: returning -1 instead of -ENOMEM is sloppy".
Signed-off-by: Santosh Nayak <santoshprasadnayak@gmail.com>
---
drivers/net/ethernet/qlogic/qla3xxx.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ethernet/qlogic/qla3xxx.c b/drivers/net/ethernet/qlogic/qla3xxx.c
index 8da3e41..df09b1c 100644
--- a/drivers/net/ethernet/qlogic/qla3xxx.c
+++ b/drivers/net/ethernet/qlogic/qla3xxx.c
@@ -2836,7 +2836,7 @@ static int ql_create_send_free_list(struct ql3_adapter *qdev)
req_q_curr++;
tx_cb->oal = kmalloc(512, GFP_KERNEL);
if (tx_cb->oal == NULL)
- return -1;
+ return -ENOMEM;
}
return 0;
}
--
1.7.4.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 2/3] qla3xxx: ethernet: Silence static checker warning.
2012-03-02 15:09 [PATCH 2/3] qla3xxx: ethernet: Silence static checker warning santosh nayak
@ 2012-03-05 21:53 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2012-03-05 21:53 UTC (permalink / raw)
To: santoshprasadnayak
Cc: jitendra.kalsaria, ron.mercer, linux-driver, netdev, linux-kernel,
kernel-janitors
From: santosh nayak <santoshprasadnayak@gmail.com>
Date: Fri, 2 Mar 2012 20:39:39 +0530
> From: Santosh Nayak <santoshprasadnayak@gmail.com>
>
> Silence the following warning:
> "warn: returning -1 instead of -ENOMEM is sloppy".
>
> Signed-off-by: Santosh Nayak <santoshprasadnayak@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-03-05 21:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-02 15:09 [PATCH 2/3] qla3xxx: ethernet: Silence static checker warning santosh nayak
2012-03-05 21:53 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).