Re: [PATCH ipsec-next v5] xfrm: Add Direction to the SA in or out

[Nicolas Dichtel <nicolas.dichtel@6wind.com>]

Le 04/04/2024 à 10:32, Antony Antony a écrit :
> This patch introduces the 'dir' attribute, 'in' or 'out', to the
> xfrm_state, SA, enhancing usability by delineating the scope of values
> based on direction. An input SA will now exclusively encompass values
> pertinent to input, effectively segregating them from output-related
> values. This change aims to streamline the configuration process and
> improve the overall clarity of SA attributes.
> 
> This feature sets the groundwork for future patches, including
> the upcoming IP-TFS patch. Additionally, the 'dir' attribute can
> serve purely informational purposes.
> It currently validates the XFRM_OFFLOAD_INBOUND flag for hardware
> offload capabilities.
Frankly, it's a poor API. It will be more confusing than useful.
This informational attribute could be wrong, there is no check.
Please consider use cases of people that don't do offload.

The kernel could accept this attribute only in case of offload. This could be
relaxed later if needed. With no check at all, nothing could be done later, once
it's in the uapi.


Regards,
Nicolas