From: Joe Perches <joe@perches.com>
To: David Miller <davem@davemloft.net>
Cc: padovan@profusion.mobi, gustavo@padovan.org,
johan.hedberg@gmail.com, linville@tuxdriver.com,
marcel@holtmann.org, netdev@vger.kernel.org
Subject: Re: pull request: bluetooth-next 2012-03-01
Date: Sat, 03 Mar 2012 12:04:20 -0800 [thread overview]
Message-ID: <1330805060.7070.18.camel@joe2Laptop> (raw)
In-Reply-To: <20120303.144722.764199641223280924.davem@davemloft.net>
On Sat, 2012-03-03 at 14:47 -0500, David Miller wrote:
> From: Gustavo Padovan <padovan@profusion.mobi>
> Date: Sat, 3 Mar 2012 13:46:55 -0300
>
> > Changing only the new code will put the Bluetooth subsystem in a
> > inconsistent coding style with different styles through the
> > subsystem.
>
> Which btw would be perfectly fine, this is how we gradually fix
> coding style in other areas of the tree too. So don't use crap
> like this as an excuse for not doing the right thing.
>
> Requiring a big "fix all the coding style" patch before starting to do
> things properly in small increments first is completely bogus.
Style conformity is important to people for lots of
different reasons.
It's your choice but I personally think you should
give the bluetooth folk a chance to change their style
in a single largish whitespace commit immediately post
3.4 akin to the recent isdn one you just pulled.
If the bluetooth folk want help, I do have scripts
that would do a pretty decent job and make all
the git blame -w changes transparent.
next prev parent reply other threads:[~2012-03-03 20:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-02 2:55 pull request: bluetooth-next 2012-03-01 Gustavo Padovan
2012-03-02 3:16 ` David Miller
2012-03-02 3:23 ` David Miller
2012-03-02 3:26 ` David Miller
2012-03-02 4:13 ` Joe Perches
2012-03-02 5:35 ` [PATCH] checkpatch: Add --strict tests for braces, comments and casts Joe Perches
2012-03-02 5:54 ` [PATCH] checkpatch: Add --strict test for strings split across multiple lines Joe Perches
2012-03-02 16:37 ` pull request: bluetooth-next 2012-03-01 Gustavo Padovan
2012-03-02 21:15 ` David Miller
2012-03-03 16:46 ` Gustavo Padovan
2012-03-03 19:46 ` David Miller
2012-03-03 19:47 ` David Miller
2012-03-03 20:04 ` Joe Perches [this message]
2012-03-03 20:06 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330805060.7070.18.camel@joe2Laptop \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=gustavo@padovan.org \
--cc=johan.hedberg@gmail.com \
--cc=linville@tuxdriver.com \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
--cc=padovan@profusion.mobi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).