From: Ben Hutchings <bhutchings@solarflare.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Roland Stigge <stigge@antcom.de>, <davem@davemloft.net>,
<jeffrey.t.kirsher@intel.com>, <alexander.h.duyck@intel.com>,
<eilong@broadcom.com>, <ian.campbell@citrix.com>,
<netdev@vger.kernel.org>, <w.sang@pengutronix.de>,
<linux-kernel@vger.kernel.org>, <kevin.wells@nxp.com>,
<linux-arm-kernel@lists.infradead.org>, <arnd@arndb.de>,
<baruch@tkos.co.il>, <joe@perches.com>
Subject: Re: [PATCH v4] lpc32xx: Added ethernet driver
Date: Tue, 6 Mar 2012 01:26:17 +0000 [thread overview]
Message-ID: <1330997177.3022.51.camel@deadeye> (raw)
In-Reply-To: <1330994958.9504.2.camel@edumazet-glaptop>
On Mon, 2012-03-05 at 16:49 -0800, Eric Dumazet wrote:
> On Mon, 2012-03-05 at 22:45 +0000, Ben Hutchings wrote:
> > On Mon, 2012-03-05 at 22:40 +0100, Roland Stigge wrote:
> > [...]
>
> ...
>
> > > + /* Copy packet from buffer */
> > > + memcpy(prdbuf,
> > > + pldat->rx_buff_v[rxconsidx], len);
> > > +
> > > + /* Pass to upper layer */
> > > + skb->protocol = eth_type_trans(skb, ndev);
> > > + netif_rx(skb);
> > > + ndev->last_rx = jiffies;
> >
> > Drivers don't need to set last_rx any more.
>
> Also, a NAPI driver should call netif_receive_skb() instead of
> netif_rx()
>
> netif_rx() is more expensive because of additional queue, while
> netif_receive_skb() directly calls the upper stacks.
Yes, but not until the poll function is changed to enable IRQs.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2012-03-06 1:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-05 21:40 [PATCH v4] lpc32xx: Added ethernet driver Roland Stigge
2012-03-05 22:45 ` Ben Hutchings
2012-03-06 0:49 ` Eric Dumazet
2012-03-06 1:26 ` Ben Hutchings [this message]
2012-03-06 8:53 ` Roland Stigge
2012-03-06 12:13 ` Eric Dumazet
2012-03-06 10:43 ` [PATCH v4] lpc32xx: Added ethernet driver: smp_wmb() Roland Stigge
2012-03-06 14:03 ` Ben Hutchings
2012-03-06 14:17 ` Russell King - ARM Linux
2012-03-06 15:37 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330997177.3022.51.camel@deadeye \
--to=bhutchings@solarflare.com \
--cc=alexander.h.duyck@intel.com \
--cc=arnd@arndb.de \
--cc=baruch@tkos.co.il \
--cc=davem@davemloft.net \
--cc=eilong@broadcom.com \
--cc=eric.dumazet@gmail.com \
--cc=ian.campbell@citrix.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=joe@perches.com \
--cc=kevin.wells@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stigge@antcom.de \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).