* [PATCH] vlan: Support sending custom Ethernet CRC.
@ 2012-03-06 2:05 greearb
2012-03-06 2:14 ` David Miller
0 siblings, 1 reply; 6+ messages in thread
From: greearb @ 2012-03-06 2:05 UTC (permalink / raw)
To: netdev; +Cc: kaber, Ben Greear
From: Ben Greear <greearb@candelatech.com>
If the underlying device supports sending custom Ethernet CRC,
then enable that feature in the VLANs as well.
NOTE: You will probably have to disable any
VLAN hardware assist on the underlying device to get
this to properly send packets with this feature enabled.
Signed-off-by: Ben Greear <greearb@candelatech.com>
---
:100644 100644 9988d4a... 6aeb0a3... M net/8021q/vlan_dev.c
net/8021q/vlan_dev.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c
index 9988d4a..6aeb0a3 100644
--- a/net/8021q/vlan_dev.c
+++ b/net/8021q/vlan_dev.c
@@ -543,6 +543,9 @@ static int vlan_dev_init(struct net_device *dev)
dev->features |= real_dev->vlan_features | NETIF_F_LLTX;
dev->gso_max_size = real_dev->gso_max_size;
+ if (netif_supports_nofcs(real_dev))
+ dev->priv_flags |= IFF_SUPP_NOFCS;
+
/* ipv6 shared card related stuff */
dev->dev_id = real_dev->dev_id;
--
1.7.3.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] vlan: Support sending custom Ethernet CRC.
2012-03-06 2:05 [PATCH] vlan: Support sending custom Ethernet CRC greearb
@ 2012-03-06 2:14 ` David Miller
2012-03-06 3:59 ` Ben Greear
0 siblings, 1 reply; 6+ messages in thread
From: David Miller @ 2012-03-06 2:14 UTC (permalink / raw)
To: greearb; +Cc: netdev, kaber
From: greearb@candelatech.com
Date: Mon, 5 Mar 2012 18:05:58 -0800
> NOTE: You will probably have to disable any
> VLAN hardware assist on the underlying device to get
> this to properly send packets with this feature enabled.
This need to be therefore handled specifically on a device-by-device
basis, and VLAN custom CRC disabled unless the device explicitly
states that it can handle this situation properly and has any
necessary feature rule enforcement codified.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] vlan: Support sending custom Ethernet CRC.
2012-03-06 2:14 ` David Miller
@ 2012-03-06 3:59 ` Ben Greear
2012-03-06 4:12 ` David Miller
0 siblings, 1 reply; 6+ messages in thread
From: Ben Greear @ 2012-03-06 3:59 UTC (permalink / raw)
To: David Miller; +Cc: netdev, kaber
On 03/05/2012 06:14 PM, David Miller wrote:
> From: greearb@candelatech.com
> Date: Mon, 5 Mar 2012 18:05:58 -0800
>
>> NOTE: You will probably have to disable any
>> VLAN hardware assist on the underlying device to get
>> this to properly send packets with this feature enabled.
>
> This need to be therefore handled specifically on a device-by-device
> basis, and VLAN custom CRC disabled unless the device explicitly
> states that it can handle this situation properly and has any
> necessary feature rule enforcement codified.
I'll see what I can come up with. Maybe figure out how to propagate
a flag up from the NIC when it is in a state that can handle VLAN + custom-CRC
and only enable the flag on the VLAN in that case...
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] vlan: Support sending custom Ethernet CRC.
2012-03-06 3:59 ` Ben Greear
@ 2012-03-06 4:12 ` David Miller
2012-03-06 16:16 ` Ben Hutchings
0 siblings, 1 reply; 6+ messages in thread
From: David Miller @ 2012-03-06 4:12 UTC (permalink / raw)
To: greearb; +Cc: netdev, kaber
From: Ben Greear <greearb@candelatech.com>
Date: Mon, 05 Mar 2012 19:59:57 -0800
> On 03/05/2012 06:14 PM, David Miller wrote:
>> From: greearb@candelatech.com
>> Date: Mon, 5 Mar 2012 18:05:58 -0800
>>
>>> NOTE: You will probably have to disable any
>>> VLAN hardware assist on the underlying device to get
>>> this to properly send packets with this feature enabled.
>>
>> This need to be therefore handled specifically on a device-by-device
>> basis, and VLAN custom CRC disabled unless the device explicitly
>> states that it can handle this situation properly and has any
>> necessary feature rule enforcement codified.
>
> I'll see what I can come up with. Maybe figure out how to propagate
> a flag up from the NIC when it is in a state that can handle VLAN +
> custom-CRC
> and only enable the flag on the VLAN in that case...
NETIF_F_CAN_VLAN_WITH_CUSTOM_CRC
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] vlan: Support sending custom Ethernet CRC.
2012-03-06 4:12 ` David Miller
@ 2012-03-06 16:16 ` Ben Hutchings
2012-03-06 19:36 ` David Miller
0 siblings, 1 reply; 6+ messages in thread
From: Ben Hutchings @ 2012-03-06 16:16 UTC (permalink / raw)
To: David Miller; +Cc: greearb, netdev, kaber
On Mon, 2012-03-05 at 23:12 -0500, David Miller wrote:
> From: Ben Greear <greearb@candelatech.com>
> Date: Mon, 05 Mar 2012 19:59:57 -0800
>
> > On 03/05/2012 06:14 PM, David Miller wrote:
> >> From: greearb@candelatech.com
> >> Date: Mon, 5 Mar 2012 18:05:58 -0800
> >>
> >>> NOTE: You will probably have to disable any
> >>> VLAN hardware assist on the underlying device to get
> >>> this to properly send packets with this feature enabled.
> >>
> >> This need to be therefore handled specifically on a device-by-device
> >> basis, and VLAN custom CRC disabled unless the device explicitly
> >> states that it can handle this situation properly and has any
> >> necessary feature rule enforcement codified.
> >
> > I'll see what I can come up with. Maybe figure out how to propagate
> > a flag up from the NIC when it is in a state that can handle VLAN +
> > custom-CRC
> > and only enable the flag on the VLAN in that case...
>
> NETIF_F_CAN_VLAN_WITH_CUSTOM_CRC
Er... vlan_features?
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] vlan: Support sending custom Ethernet CRC.
2012-03-06 16:16 ` Ben Hutchings
@ 2012-03-06 19:36 ` David Miller
0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2012-03-06 19:36 UTC (permalink / raw)
To: bhutchings; +Cc: greearb, netdev, kaber
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Tue, 6 Mar 2012 16:16:34 +0000
> On Mon, 2012-03-05 at 23:12 -0500, David Miller wrote:
>> From: Ben Greear <greearb@candelatech.com>
>> Date: Mon, 05 Mar 2012 19:59:57 -0800
>>
>> > On 03/05/2012 06:14 PM, David Miller wrote:
>> >> From: greearb@candelatech.com
>> >> Date: Mon, 5 Mar 2012 18:05:58 -0800
>> >>
>> >>> NOTE: You will probably have to disable any
>> >>> VLAN hardware assist on the underlying device to get
>> >>> this to properly send packets with this feature enabled.
>> >>
>> >> This need to be therefore handled specifically on a device-by-device
>> >> basis, and VLAN custom CRC disabled unless the device explicitly
>> >> states that it can handle this situation properly and has any
>> >> necessary feature rule enforcement codified.
>> >
>> > I'll see what I can come up with. Maybe figure out how to propagate
>> > a flag up from the NIC when it is in a state that can handle VLAN +
>> > custom-CRC
>> > and only enable the flag on the VLAN in that case...
>>
>> NETIF_F_CAN_VLAN_WITH_CUSTOM_CRC
>
> Er... vlan_features?
Right.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-03-06 19:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-06 2:05 [PATCH] vlan: Support sending custom Ethernet CRC greearb
2012-03-06 2:14 ` David Miller
2012-03-06 3:59 ` Ben Greear
2012-03-06 4:12 ` David Miller
2012-03-06 16:16 ` Ben Hutchings
2012-03-06 19:36 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).