netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: therbert@google.com
Cc: davem@davemloft.net, eric.dumazet@gmail.com,
	netdev@vger.kernel.org,
	Paul Gortmaker <paul.gortmaker@windriver.com>
Subject: [PATCH] net: make CONFIG_BQL actually end user configurable
Date: Mon,  5 Mar 2012 22:38:16 -0500	[thread overview]
Message-ID: <1331005096-12332-1-git-send-email-paul.gortmaker@windriver.com> (raw)

Without the defining string or help text, LKC won't ever bother
to ask the end user for a setting for CONFIG_BQL -- you could
delete it from your .config and run make oldconfig and not a
thing would change -- it would still be silently re-enabled.

While most people will have no reason to turn this off, the
ability to do so can be useful for testing BQL support additions
on previously BQL-unaware drivers and similar.

The kconfig help text is largely taken from the original RFC
patchset 0/N header sent to netdev@vger.kernel.org in fall 2011.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---

[Apologies if this was explicitly blocked for a reason; I couldn't
 find a reason after searching netdev or threads at bufferbloat.net ]

diff --git a/net/Kconfig b/net/Kconfig
index e07272d..fd1d815 100644
--- a/net/Kconfig
+++ b/net/Kconfig
@@ -241,10 +241,15 @@ config NETPRIO_CGROUP
 	  a per-interface basis
 
 config BQL
-	boolean
+	boolean	"Byte Queue Limits"
 	depends on SYSFS
 	select DQL
 	default y
+	---help---
+	  Byte queue limits are a mechanism to limit the size of the transmit
+	  hardware queue on a NIC by a number of bytes. The goal of these byte
+	  queue limits is to reduce latency caused by excessive queuing in
+	  hardware without sacrificing throughput.
 
 config HAVE_BPF_JIT
 	bool
-- 
1.7.9.1

             reply	other threads:[~2012-03-06  3:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-06  3:38 Paul Gortmaker [this message]
     [not found] ` <CAA93jw5HadpvBvtZvf6ArK3tdm=7Cs9sLYeHO9WN6rJOfPLPbA@mail.gmail.com>
2012-03-06  4:09   ` [PATCH] net: make CONFIG_BQL actually end user configurable Paul Gortmaker
2012-03-06  5:57     ` Tom Herbert
2012-03-06  4:11 ` David Miller
2012-03-06  4:11 ` John Fastabend
2012-03-06  4:17   ` Paul Gortmaker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1331005096-12332-1-git-send-email-paul.gortmaker@windriver.com \
    --to=paul.gortmaker@windriver.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=therbert@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).