From: Eric Dumazet <eric.dumazet@gmail.com>
To: Roland Stigge <stigge@antcom.de>
Cc: Ben Hutchings <bhutchings@solarflare.com>,
davem@davemloft.net, jeffrey.t.kirsher@intel.com,
alexander.h.duyck@intel.com, eilong@broadcom.com,
ian.campbell@citrix.com, netdev@vger.kernel.org,
w.sang@pengutronix.de, linux-kernel@vger.kernel.org,
kevin.wells@nxp.com, linux-arm-kernel@lists.infradead.org,
arnd@arndb.de, baruch@tkos.co.il, joe@perches.com
Subject: Re: [PATCH v4] lpc32xx: Added ethernet driver
Date: Tue, 06 Mar 2012 04:13:50 -0800 [thread overview]
Message-ID: <1331036030.2474.40.camel@edumazet-laptop> (raw)
In-Reply-To: <4F55D099.5070006@antcom.de>
Le mardi 06 mars 2012 à 09:53 +0100, Roland Stigge a écrit :
> Sounds reasonable, and will do it.
>
> However, I implemented it from the example of
> drivers/net/ethernet/via/via-velocity.c:velocity_poll() - is there a
> good reason for doing it that way in the velocity driver or is it done
> incorrectly there, also?
>
Its done in a non efficient way.
It works as is, but its not the right thing to do.
The NAPI port was very minimal on via-velocity it seems.
A better way is to hold no locks in the RX handler, allowing calls to
netif_receive_skb() [ and potential calls to xmit while handling this
incoming skbs ]
Problem of saying "we dont expect to be SMP anyway", is that this let
reference material for future drivers that will copy/paste the code,
then experience performance problems.
next prev parent reply other threads:[~2012-03-06 12:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-05 21:40 [PATCH v4] lpc32xx: Added ethernet driver Roland Stigge
2012-03-05 22:45 ` Ben Hutchings
2012-03-06 0:49 ` Eric Dumazet
2012-03-06 1:26 ` Ben Hutchings
2012-03-06 8:53 ` Roland Stigge
2012-03-06 12:13 ` Eric Dumazet [this message]
2012-03-06 10:43 ` [PATCH v4] lpc32xx: Added ethernet driver: smp_wmb() Roland Stigge
2012-03-06 14:03 ` Ben Hutchings
2012-03-06 14:17 ` Russell King - ARM Linux
2012-03-06 15:37 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1331036030.2474.40.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=alexander.h.duyck@intel.com \
--cc=arnd@arndb.de \
--cc=baruch@tkos.co.il \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=eilong@broadcom.com \
--cc=ian.campbell@citrix.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=joe@perches.com \
--cc=kevin.wells@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stigge@antcom.de \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox