From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Hutchings Subject: Re: [patch] e1000e, igbvf: fix default message level Date: Sat, 10 Mar 2012 23:06:29 +0000 Message-ID: <1331420789.3022.100.camel@deadeye> References: <20120310084921.GA4647@elgon.mountain> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Jeff Kirsher , Jesse Brandeburg , Bruce Allan , Carolyn Wyborny , Don Skidmore , Greg Rose , Peter P Waskiewicz Jr , Alex Duyck , John Ronciak , "David S. Miller" , , , To: Dan Carpenter Return-path: Received: from mail.solarflare.com ([216.237.3.220]:55290 "EHLO ocex02.SolarFlarecom.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752482Ab2CJXGi (ORCPT ); Sat, 10 Mar 2012 18:06:38 -0500 In-Reply-To: <20120310084921.GA4647@elgon.mountain> Sender: netdev-owner@vger.kernel.org List-ID: On Sat, 2012-03-10 at 11:49 +0300, Dan Carpenter wrote: > The intent here was to enable both NETIF_MSG_DRV and NETIF_MSG_PROBE > messages, but in the original code only the NETIF_MSG_DRV bit was set. > > NETIF_MSG_DRV and NETIF_MSG_PROBE are bits 0 and 1, they are not > supposed to be used to do a shift. I think the confusion is because > the msg_enable can also be controlled through ethtool which passes a bit > number that is used to do a bit shift. [...] No, the ethtool interface also uses a mask. However netif_msg_init() is commonly used to initialise the msg_enable mask based on a module parameter that's a bit number. Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.